C++: Address review comment

jketema · jketema · commit 12da4f7814a1 · 2023-03-28T00:33:46.000+02:00
diff --git a/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/RangeAnalysisStage.qll b/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/RangeAnalysisStage.qll
@@ -1045,6 +1045,8 @@ module RangeStage<DeltaSig D, BoundSig<D> Bounds, LangSig<D> LangParam, UtilSig<
         boolean fbe1, boolean fbe2, D::Delta od1, D::Delta od2, SemReason r1, SemReason r2
       |
         rem = e and
+        not (upper = true and semPositive(rem.getRightOperand())) and
+        not (upper = true and semPositive(rem.getLeftOperand())) and
         boundedRemExpr(rem, b1, true, d1, fbe1, od1, r1) and
         boundedRemExpr(rem, b2, false, d2, fbe2, od2, r2) and
         (

Original file line number	Diff line number	Diff line change
`@@ -1045,6 +1045,8 @@ module RangeStage<DeltaSig D, BoundSig<D> Bounds, LangSig<D> LangParam, UtilSig<`
`1045`	`1045`	`boolean fbe1, boolean fbe2, D::Delta od1, D::Delta od2, SemReason r1, SemReason r2`
`1046`	`1046`	`\|`
`1047`	`1047`	`rem = e and`
	`1048`	`+ not (upper = true and semPositive(rem.getRightOperand())) and`
	`1049`	`+ not (upper = true and semPositive(rem.getLeftOperand())) and`
`1048`	`1050`	`boundedRemExpr(rem, b1, true, d1, fbe1, od1, r1) and`
`1049`	`1051`	`boundedRemExpr(rem, b2, false, d2, fbe2, od2, r2) and`
`1050`	`1052`	`(`