use getImportedModuleNode()

erik-krogh · asgerf · web-flow · commit 138a16f0b30b · 2022-11-09T09:53:23.000+01:00
Co-authored-by: Asger F &lt;asgerf@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/PackageExports.qll b/javascript/ql/lib/semmle/javascript/PackageExports.qll
@@ -81,7 +81,7 @@ private DataFlow::Node getAValueExportedByPackage() {
   // `module.exports.bar = function () { ... };`
   exists(DataFlow::PropRead read, Import imp |
     read = getAValueExportedByPackage() and
-    read.getBase().getALocalSource().getEnclosingExpr() = imp and
+    read.getBase().getALocalSource() = imp.getImportedModuleNode() and
     result = imp.getImportedModule().getAnExportedValue(read.getPropertyName())
   )
   or

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ private DataFlow::Node getAValueExportedByPackage() {`
`81`	`81`	// `module.exports.bar = function () { ... };`
`82`	`82`	`exists(DataFlow::PropRead read, Import imp \|`
`83`	`83`	`read = getAValueExportedByPackage() and`
`84`		`- read.getBase().getALocalSource().getEnclosingExpr() = imp and`
	`84`	`+ read.getBase().getALocalSource() = imp.getImportedModuleNode() and`
`85`	`85`	`result = imp.getImportedModule().getAnExportedValue(read.getPropertyName())`
`86`	`86`	`)`
`87`	`87`	`or`