Skip to content

Commit 15c9e76

Browse files
committed
Ruby: convert rb/sensitive-get-query into a @kind problem
1 parent 329684c commit 15c9e76

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

ruby/ql/src/queries/security/cwe-598/SensitiveGetQuery.ql

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* @name Sensitive data read from GET request
33
* @description Placing sensitive data in a GET request increases the risk of
44
* the data being exposed to an attacker.
5-
* @kind path-problem
5+
* @kind problem
66
* @problem.severity warning
77
* @security-severity 6.5
88
* @precision high
@@ -12,12 +12,10 @@
1212
*/
1313

1414
import ruby
15-
import DataFlow::PathGraph
1615
import codeql.ruby.security.SensitiveGetQueryQuery
1716
import codeql.ruby.security.SensitiveActions
1817

19-
from DataFlow::PathNode source, DataFlow::PathNode sink, SensitiveGetQuery::Configuration config
20-
where config.hasFlowPath(source, sink)
21-
select source.getNode(), source, sink,
22-
"$@ for GET requests uses query parameter as sensitive data.",
23-
source.getNode().(SensitiveGetQuery::Source).getHandler(), "Route handler"
18+
from DataFlow::Node source, DataFlow::Node sink, SensitiveGetQuery::Configuration config
19+
where config.hasFlow(source, sink)
20+
select source, "$@ for GET requests uses query parameter as sensitive data.",
21+
source.(SensitiveGetQuery::Source).getHandler(), "Route handler"

0 commit comments

Comments
 (0)