Skip to content

Commit 16a1192

Browse files
committed
Swift: remove toString() = "call to call to ..."
1 parent 91f35a5 commit 16a1192

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

swift/ql/lib/codeql/swift/elements/expr/ApplyExpr.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,4 @@ private class FullDotSyntaxBaseIgnoredApplyExpr extends ApplyExpr {
5656
FullDotSyntaxBaseIgnoredApplyExpr() { expr = this.getFunction() }
5757

5858
override AutoClosureExpr getStaticTarget() { result = expr.getStaticTarget().getExpr() }
59-
60-
override string toString() { result = "call to " + expr }
6159
}

swift/ql/test/library-tests/elements/expr/methodlookup/PrintAst.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ methodlookup.swift:
117117
# 26| getElement(3): [CallExpr] call to instanceMethod()
118118
# 26| getFunction(): [MethodLookupExpr] .instanceMethod()
119119
# 26| getBase(): [DeclRefExpr] foo
120-
# 27| getElement(4): [CallExpr] call to call to Foo.instanceMethod()
120+
# 27| getElement(4): [CallExpr] call to { ... }
121121
# 27| getFunction(): [CallExpr] call to Foo.instanceMethod()
122122
# 27| getFunction(): [DotSyntaxBaseIgnoredExpr] Foo.instanceMethod()
123123
# 27| getQualifier(): [TypeExpr] Foo.Type
@@ -210,7 +210,7 @@ methodlookup.swift:
210210
# 47| getFunction(): [MethodLookupExpr] .instanceMethod()
211211
# 47| getBase(): [DeclRefExpr] baz
212212
# 47| getElement(3).getFullyConverted(): [AwaitExpr] await ...
213-
# 48| getElement(4): [CallExpr] call to call to Baz.instanceMethod()
213+
# 48| getElement(4): [CallExpr] call to { ... }
214214
# 48| getFunction(): [CallExpr] call to Baz.instanceMethod()
215215
# 48| getFunction(): [DotSyntaxBaseIgnoredExpr] Baz.instanceMethod()
216216
# 48| getQualifier(): [TypeExpr] Baz.Type

swift/ql/test/library-tests/elements/expr/methodlookup/getStaticTarget.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ noStaticTarget
2323
| methodlookup.swift:24:9:24:18 | call to Foo.init() | true | Foo.init() |
2424
| methodlookup.swift:26:5:26:24 | call to instanceMethod() | true | instanceMethod() |
2525
| methodlookup.swift:27:5:27:27 | call to Foo.instanceMethod() | true | { ... } |
26-
| methodlookup.swift:27:5:27:29 | call to call to Foo.instanceMethod() | true | { ... } |
26+
| methodlookup.swift:27:5:27:29 | call to { ... } | true | { ... } |
2727
| methodlookup.swift:27:9:27:9 | call to instanceMethod() | true | instanceMethod() |
2828
| methodlookup.swift:29:5:29:21 | call to classMethod() | true | classMethod() |
2929
| methodlookup.swift:30:5:30:22 | call to staticMethod() | true | staticMethod() |
@@ -37,7 +37,7 @@ noStaticTarget
3737
| methodlookup.swift:45:15:45:24 | call to Baz.init() | true | Baz.init() |
3838
| methodlookup.swift:47:11:47:30 | call to instanceMethod() | true | instanceMethod() |
3939
| methodlookup.swift:48:11:48:33 | call to Baz.instanceMethod() | true | { ... } |
40-
| methodlookup.swift:48:11:48:35 | call to call to Baz.instanceMethod() | true | { ... } |
40+
| methodlookup.swift:48:11:48:35 | call to { ... } | true | { ... } |
4141
| methodlookup.swift:48:15:48:15 | call to instanceMethod() | true | instanceMethod() |
4242
| methodlookup.swift:50:11:50:27 | call to classMethod() | true | classMethod() |
4343
| methodlookup.swift:51:11:51:28 | call to staticMethod() | true | staticMethod() |

0 commit comments

Comments
 (0)