Update javascript/ql/src/semmle/javascript/security/IncompleteBlacklistSanitizer.qll

erik-krogh · asgerf · web-flow · commit 1db5cb15f018 · 2021-03-17T13:30:05.000+01:00
Co-authored-by: Asger F &lt;asgerf@github.com&gt;
diff --git a/javascript/ql/src/semmle/javascript/security/IncompleteBlacklistSanitizer.qll b/javascript/ql/src/semmle/javascript/security/IncompleteBlacklistSanitizer.qll
@@ -53,7 +53,7 @@ class StringReplaceCallSequence extends DataFlow::CallNode {
   string getAReplacementString() {
     getAMember().replaces(_, result)
     or
-    // StringReplaceCall::replaces/2 can't always find the `old` string, so this is added as a falback.
+    // StringReplaceCall::replaces/2 can't always find the `old` string, so this is added as a fallback.
     getAMember().getRawReplacement().getStringValue() = result
   }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class StringReplaceCallSequence extends DataFlow::CallNode {`
`53`	`53`	`string getAReplacementString() {`
`54`	`54`	`getAMember().replaces(_, result)`
`55`	`55`	`or`
`56`		- // StringReplaceCall::replaces/2 can't always find the `old` string, so this is added as a falback.
	`56`	+ // StringReplaceCall::replaces/2 can't always find the `old` string, so this is added as a fallback.
`57`	`57`	`getAMember().getRawReplacement().getStringValue() = result`
`58`	`58`	`}`
`59`	`59`