Skip to content

Commit 2235634

Browse files
committed
update consistency comments for CWE-754
1 parent 0d64a0f commit 2235634

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

javascript/ql/test/query-tests/Security/CWE-754/UnsafeDynamicMethodAccess.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ let obj = {};
44

55
window.addEventListener('message', (ev) => {
66
let message = JSON.parse(ev.data);
7-
window[message.name](message.payload); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
8-
new window[message.name](message.payload); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
7+
window[message.name](message.payload); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
8+
new window[message.name](message.payload); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
99
window["HTMLElement" + message.name](message.payload); // OK - concatenation restricts choice of methods
1010
window[`HTMLElement${message.name}`](message.payload); // OK - concatenation restricts choice of methods
1111

1212
function f() {}
13-
f[message.name](message.payload)(); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
13+
f[message.name](message.payload)(); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
1414

1515
obj[message.name](message.payload); // NOT OK
1616

17-
window[ev](ev); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
17+
window[ev](ev); // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
1818
});

javascript/ql/test/query-tests/Security/CWE-754/tst.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
obj[name](); // NOT OK
2929

3030
if (obj.hasOwnProperty(name)) {
31-
obj[name](); // NOT OK, but not flagged
31+
obj[name](); // NOT OK, but not flagged [INCONSISTENCY]
3232
}
3333

3434
let key = "$" + name;
3535
obj[key](); // NOT OK
3636
if (typeof obj[key] === 'function')
37-
obj[key](); // OK - but still flagged
37+
obj[key](); // OK - but still flagged [INCONSISTENCY]
3838

3939
if (typeof fn === 'function') {
4040
fn.apply(obj); // OK

0 commit comments

Comments
 (0)