File tree Expand file tree Collapse file tree 2 files changed +6
-6
lines changed
javascript/ql/test/query-tests/Security/CWE-754 Expand file tree Collapse file tree 2 files changed +6
-6
lines changed Original file line number Diff line number Diff line change @@ -4,15 +4,15 @@ let obj = {};
4
4
5
5
window . addEventListener ( 'message' , ( ev ) => {
6
6
let message = JSON . parse ( ev . data ) ;
7
- window [ message . name ] ( message . payload ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
8
- new window [ message . name ] ( message . payload ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
7
+ window [ message . name ] ( message . payload ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
8
+ new window [ message . name ] ( message . payload ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
9
9
window [ "HTMLElement" + message . name ] ( message . payload ) ; // OK - concatenation restricts choice of methods
10
10
window [ `HTMLElement${ message . name } ` ] ( message . payload ) ; // OK - concatenation restricts choice of methods
11
11
12
12
function f ( ) { }
13
- f [ message . name ] ( message . payload ) ( ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
13
+ f [ message . name ] ( message . payload ) ( ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
14
14
15
15
obj [ message . name ] ( message . payload ) ; // NOT OK
16
16
17
- window [ ev ] ( ev ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql
17
+ window [ ev ] ( ev ) ; // NOT OK, but reported by UnsafeDynamicMethodAccess.ql [INCONSISTENCY]
18
18
} ) ;
Original file line number Diff line number Diff line change 28
28
obj [ name ] ( ) ; // NOT OK
29
29
30
30
if ( obj . hasOwnProperty ( name ) ) {
31
- obj [ name ] ( ) ; // NOT OK, but not flagged
31
+ obj [ name ] ( ) ; // NOT OK, but not flagged [INCONSISTENCY]
32
32
}
33
33
34
34
let key = "$" + name ;
35
35
obj [ key ] ( ) ; // NOT OK
36
36
if ( typeof obj [ key ] === 'function' )
37
- obj [ key ] ( ) ; // OK - but still flagged
37
+ obj [ key ] ( ) ; // OK - but still flagged [INCONSISTENCY]
38
38
39
39
if ( typeof fn === 'function' ) {
40
40
fn . apply ( obj ) ; // OK
You can’t perform that action at this time.
0 commit comments