Python: Simplify CgiFieldStorageFieldKind.getTaintOfAttribute

RasmusWL · RasmusWL · commit 23f3736b679c · 2020-04-24T08:04:55.000+02:00
diff --git a/python/ql/src/semmle/python/web/stdlib/Request.qll b/python/ql/src/semmle/python/web/stdlib/Request.qll
@@ -117,10 +117,8 @@ class CgiFieldStorageFieldKind extends TaintKind {
     CgiFieldStorageFieldKind() { this = "CgiFieldStorageFieldKind" }
 
     override TaintKind getTaintOfAttribute(string name) {
-        name = "filename" and result instanceof ExternalStringKind
+        name in ["filename", "value"] and result instanceof ExternalStringKind
         or
         name = "file" and result instanceof ExternalFileObject
-        or
-        name = "value" and result instanceof ExternalStringKind
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -117,10 +117,8 @@ class CgiFieldStorageFieldKind extends TaintKind {`
`117`	`117`	`CgiFieldStorageFieldKind() { this = "CgiFieldStorageFieldKind" }`
`118`	`118`
`119`	`119`	`override TaintKind getTaintOfAttribute(string name) {`
`120`		`- name = "filename" and result instanceof ExternalStringKind`
	`120`	`+ name in ["filename", "value"] and result instanceof ExternalStringKind`
`121`	`121`	`or`
`122`	`122`	`name = "file" and result instanceof ExternalFileObject`
`123`		`- or`
`124`		`- name = "value" and result instanceof ExternalStringKind`
`125`	`123`	`}`
`126`	`124`	`}`