Skip to content

Commit 26ae8f1

Browse files
committed
Swift: accept test changes
Downgrading the emit object action to a type check one has some unexpected side effects, that seem however acceptable: * experimental false static assertions do not make compilation fail in type check mode * the implicit module loading of `SwiftOnoneSupport` is not happening. That module contains some "pre-specializations", it does not seem really relevant for analysis
1 parent d35c5e9 commit 26ae8f1

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
| file://:0:0:0:0 | Foo | getModule: | file://:0:0:0:0 | Foo | getInterfaceType: | module<Foo> | getName: | Foo | getNumberOfBaseTypes: | 0 | isBuiltinModule: | no | isSystemModule: | no | getNumberOfImportedModules: | 4 | getNumberOfExportedModules: | 1 |
1+
| file://:0:0:0:0 | Foo | getModule: | file://:0:0:0:0 | Foo | getInterfaceType: | module<Foo> | getName: | Foo | getNumberOfBaseTypes: | 0 | isBuiltinModule: | no | isSystemModule: | no | getNumberOfImportedModules: | 3 | getNumberOfExportedModules: | 1 |
22
| file://:0:0:0:0 | __ObjC | getModule: | file://:0:0:0:0 | __ObjC | getInterfaceType: | module<__ObjC> | getName: | __ObjC | getNumberOfBaseTypes: | 0 | isBuiltinModule: | no | isSystemModule: | no | getNumberOfImportedModules: | 1 | getNumberOfExportedModules: | 0 |
3-
| file://:0:0:0:0 | default_module_name | getModule: | file://:0:0:0:0 | default_module_name | getInterfaceType: | module<default_module_name> | getName: | default_module_name | getNumberOfBaseTypes: | 0 | isBuiltinModule: | no | isSystemModule: | no | getNumberOfImportedModules: | 4 | getNumberOfExportedModules: | 0 |
3+
| file://:0:0:0:0 | default_module_name | getModule: | file://:0:0:0:0 | default_module_name | getInterfaceType: | module<default_module_name> | getName: | default_module_name | getNumberOfBaseTypes: | 0 | isBuiltinModule: | no | isSystemModule: | no | getNumberOfImportedModules: | 3 | getNumberOfExportedModules: | 0 |
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
| file://:0:0:0:0 | Foo | 0 | file://:0:0:0:0 | Swift |
22
| file://:0:0:0:0 | Foo | 1 | file://:0:0:0:0 | _StringProcessing |
33
| file://:0:0:0:0 | Foo | 2 | file://:0:0:0:0 | _Concurrency |
4-
| file://:0:0:0:0 | Foo | 3 | file://:0:0:0:0 | SwiftOnoneSupport |
54
| file://:0:0:0:0 | __ObjC | 0 | file://:0:0:0:0 | Swift |
65
| file://:0:0:0:0 | default_module_name | 0 | file://:0:0:0:0 | Swift |
76
| file://:0:0:0:0 | default_module_name | 1 | file://:0:0:0:0 | _StringProcessing |
87
| file://:0:0:0:0 | default_module_name | 2 | file://:0:0:0:0 | _Concurrency |
9-
| file://:0:0:0:0 | default_module_name | 3 | file://:0:0:0:0 | SwiftOnoneSupport |
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
| static_assert.swift:2:1:2:15 | #assert ... | getCondition: | static_assert.swift:2:9:2:14 | ... .==(_:_:) ... | getMessage: | |
22
| static_assert.swift:3:1:3:24 | #assert ... | getCondition: | static_assert.swift:3:9:3:14 | ... .!=(_:_:) ... | getMessage: | hello |
3-
| static_failing_assert.swift:4:1:4:24 | #assert ... | getCondition: | static_failing_assert.swift:4:9:4:14 | ... .==(_:_:) ... | getMessage: | oh my |
3+
| static_failing_assert.swift:3:1:3:24 | #assert ... | getCondition: | static_failing_assert.swift:3:9:3:14 | ... .==(_:_:) ... | getMessage: | oh my |
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
//codeql-extractor-options: -enable-experimental-static-assert
2-
//codeql-extractor-expected-status: 1
32

43
#assert(1 == 0, "oh my")

0 commit comments

Comments
 (0)