|
| 1 | + |
| 2 | +// --- Foundation stubs --- |
| 3 | + |
| 4 | +class NSObject { |
| 5 | +} |
| 6 | + |
| 7 | +struct URL { |
| 8 | +} |
| 9 | + |
| 10 | +struct URLRequest { |
| 11 | +} |
| 12 | + |
| 13 | +class URLResponse: NSObject { |
| 14 | +} |
| 15 | + |
| 16 | +class HTTPURLResponse : URLResponse { |
| 17 | +} |
| 18 | + |
| 19 | +// --- Alamofire stubs --- |
| 20 | + |
| 21 | +protocol URLConvertible { |
| 22 | +} |
| 23 | + |
| 24 | +extension String: URLConvertible { |
| 25 | +} |
| 26 | + |
| 27 | +struct HTTPMethod { |
| 28 | + static let get = HTTPMethod(rawValue: "GET") |
| 29 | + static let post = HTTPMethod(rawValue: "POST") |
| 30 | + |
| 31 | + init(rawValue: String) {} |
| 32 | +} |
| 33 | + |
| 34 | +struct HTTPHeaders { |
| 35 | + init(_ dictionary: [String: String]) {} |
| 36 | + |
| 37 | + mutating func add(name: String, value: String) {} |
| 38 | + mutating func update(name: String, value: String) {} |
| 39 | +} |
| 40 | + |
| 41 | +extension HTTPHeaders: ExpressibleByDictionaryLiteral { |
| 42 | + public init(dictionaryLiteral elements: (String, String)...) {} |
| 43 | +} |
| 44 | + |
| 45 | +typealias Parameters = [String: Any] |
| 46 | + |
| 47 | +protocol ParameterEncoding { |
| 48 | +} |
| 49 | + |
| 50 | +struct URLEncoding: ParameterEncoding { |
| 51 | + static var `default`: URLEncoding { URLEncoding() } |
| 52 | +} |
| 53 | + |
| 54 | +protocol ParameterEncoder { |
| 55 | +} |
| 56 | + |
| 57 | +class URLEncodedFormParameterEncoder: ParameterEncoder { |
| 58 | + static var `default`: URLEncodedFormParameterEncoder { URLEncodedFormParameterEncoder() } |
| 59 | +} |
| 60 | + |
| 61 | +protocol RequestInterceptor { |
| 62 | +} |
| 63 | + |
| 64 | +class Request { |
| 65 | +} |
| 66 | + |
| 67 | +class DataRequest: Request { |
| 68 | +} |
| 69 | + |
| 70 | +final class DataStreamRequest: Request { |
| 71 | +} |
| 72 | + |
| 73 | +class DownloadRequest: Request { |
| 74 | + struct Options: OptionSet { |
| 75 | + let rawValue: Int |
| 76 | + |
| 77 | + init(rawValue: Int) { |
| 78 | + self.rawValue = rawValue |
| 79 | + } |
| 80 | + } |
| 81 | + |
| 82 | + typealias Destination = |
| 83 | + (_ temporaryURL: URL, _ response: HTTPURLResponse) -> |
| 84 | + (destinationURL: URL, options: Options) |
| 85 | +} |
| 86 | + |
| 87 | +class Session { |
| 88 | + static let `default` = Session() |
| 89 | + |
| 90 | + typealias RequestModifier = (inout URLRequest) throws -> Void |
| 91 | + |
| 92 | + func request( |
| 93 | + _ convertible: URLConvertible, |
| 94 | + method: HTTPMethod = .get, |
| 95 | + parameters: Parameters? = nil, |
| 96 | + encoding: ParameterEncoding = URLEncoding.default, |
| 97 | + headers: HTTPHeaders? = nil, |
| 98 | + interceptor: RequestInterceptor? = nil, |
| 99 | + requestModifier: RequestModifier? = nil) -> DataRequest { |
| 100 | + return DataRequest() |
| 101 | + } |
| 102 | + |
| 103 | + func request<Parameters: Encodable>( |
| 104 | + _ convertible: URLConvertible, |
| 105 | + method: HTTPMethod = .get, |
| 106 | + parameters: Parameters? = nil, |
| 107 | + encoder: ParameterEncoder = URLEncodedFormParameterEncoder.default, |
| 108 | + headers: HTTPHeaders? = nil, |
| 109 | + interceptor: RequestInterceptor? = nil, |
| 110 | + requestModifier: RequestModifier? = nil) -> DataRequest { |
| 111 | + return DataRequest() |
| 112 | + } |
| 113 | + |
| 114 | + func streamRequest( |
| 115 | + _ convertible: URLConvertible, |
| 116 | + method: HTTPMethod = .get, |
| 117 | + headers: HTTPHeaders? = nil, |
| 118 | + automaticallyCancelOnStreamError: Bool = false, |
| 119 | + interceptor: RequestInterceptor? = nil, |
| 120 | + requestModifier: RequestModifier? = nil) -> DataStreamRequest { |
| 121 | + return DataStreamRequest() |
| 122 | + } |
| 123 | + |
| 124 | + func download( |
| 125 | + _ convertible: URLConvertible, |
| 126 | + method: HTTPMethod = .get, |
| 127 | + parameters: Parameters? = nil, |
| 128 | + encoding: ParameterEncoding = URLEncoding.default, |
| 129 | + headers: HTTPHeaders? = nil, |
| 130 | + interceptor: RequestInterceptor? = nil, |
| 131 | + requestModifier: RequestModifier? = nil, |
| 132 | + to destination: DownloadRequest.Destination? = nil) -> DownloadRequest { |
| 133 | + return DownloadRequest() |
| 134 | + } |
| 135 | + |
| 136 | + // (there are many more variants of `request`, `streamRequest` and `download`) |
| 137 | +} |
| 138 | + |
| 139 | +let AF = Session.default |
| 140 | + |
| 141 | +// --- tests --- |
| 142 | + |
| 143 | +struct MyEncodable: Encodable { |
| 144 | + let value: String |
| 145 | +} |
| 146 | + |
| 147 | +func test1(username: String, password: String, email: String, harmless: String) { |
| 148 | + // sensitive data in URL |
| 149 | + |
| 150 | + AF.request("http://example.com/login?p=" + password) // BAD |
| 151 | + AF.request("http://example.com/login?h=" + harmless) // GOOD (not sensitive) |
| 152 | + AF.streamRequest("http://example.com/login?p=" + password) // BAD |
| 153 | + AF.streamRequest("http://example.com/login?h=" + harmless) // GOOD (not sensitive) |
| 154 | + AF.download("http://example.com/" + email + ".html") // BAD |
| 155 | + AF.download("http://example.com/" + harmless + ".html") // GOOD (not sensitive) |
| 156 | + |
| 157 | + // sensitive data in parameters |
| 158 | + |
| 159 | + let params1 = ["value": email] |
| 160 | + let params2 = ["value": harmless] |
| 161 | + |
| 162 | + AF.request("http://example.com/", parameters: params1) // BAD [NOT DETECTED] |
| 163 | + AF.request("http://example.com/", parameters: params2) // GOOD (not sensitive) |
| 164 | + AF.request("http://example.com/", parameters: params1, encoding: URLEncoding.default) // BAD [NOT DETECTED] |
| 165 | + AF.request("http://example.com/", parameters: params2, encoding: URLEncoding.default) // GOOD (not sensitive) |
| 166 | + AF.request("http://example.com/", parameters: params1, encoder: URLEncodedFormParameterEncoder.default) // BAD [NOT DETECTED] |
| 167 | + AF.request("http://example.com/", parameters: params2, encoder: URLEncodedFormParameterEncoder.default) // GOOD (not sensitive) |
| 168 | + AF.download("http://example.com/", parameters: params1) // BAD [NOT DETECTED] |
| 169 | + AF.download("http://example.com/", parameters: params2) // GOOD (not sensitive) |
| 170 | + |
| 171 | + let params3 = ["values": ["...", email, "..."]] |
| 172 | + let params4 = ["values": ["...", harmless, "..."]] |
| 173 | + |
| 174 | + AF.request("http://example.com/", method:.post, parameters: params3) // BAD [NOT DETECTED] |
| 175 | + AF.request("http://example.com/", method:.post, parameters: params4) // GOOD (not sensitive) |
| 176 | + |
| 177 | + let params5 = MyEncodable(value: email) |
| 178 | + let params6 = MyEncodable(value: harmless) |
| 179 | + |
| 180 | + AF.request("http://example.com/", parameters: params5) // BAD [NOT DETECTED] |
| 181 | + AF.request("http://example.com/", parameters: params6) // GOOD (not sensitive) |
| 182 | + |
| 183 | + // request headers |
| 184 | + // - in real usage a password here would normally be base64 encoded for transmission |
| 185 | + // - the risk is greatly reduced (but not eliminated) if HTTPS is used |
| 186 | + |
| 187 | + let headers1: HTTPHeaders = ["Authorization": username + ":" + password] |
| 188 | + let headers2: HTTPHeaders = ["Value": harmless] |
| 189 | + |
| 190 | + AF.request("http://example.com/", headers: headers1) // BAD [NOT DETECTED] |
| 191 | + AF.request("http://example.com/", headers: headers2) // GOOD (not sensitive) |
| 192 | + AF.streamRequest("http://example.com/", headers: headers1) // BAD [NOT DETECTED] |
| 193 | + AF.streamRequest("http://example.com/", headers: headers2) // GOOD (not sensitive) |
| 194 | + |
| 195 | + let headers3 = HTTPHeaders(["Authorization": username + ":" + password]) |
| 196 | + let headers4 = HTTPHeaders(["Value": harmless]) |
| 197 | + |
| 198 | + AF.request("http://example.com/", headers: headers3) // BAD [NOT DETECTED] |
| 199 | + AF.request("http://example.com/", headers: headers4) // GOOD (not sensitive) |
| 200 | + AF.download("http://example.com/", headers: headers1) // BAD [NOT DETECTED] |
| 201 | + AF.download("http://example.com/", headers: headers2) // GOOD (not sensitive) |
| 202 | + |
| 203 | + var headers5 = HTTPHeaders([:]) |
| 204 | + var headers6 = HTTPHeaders([:]) |
| 205 | + headers5.add(name: "Authorization", value: username + ":" + password) |
| 206 | + headers6.add(name: "Data", value: harmless) |
| 207 | + |
| 208 | + AF.request("http://example.com/", headers: headers5) // BAD [NOT DETECTED] |
| 209 | + AF.request("http://example.com/", headers: headers6) // GOOD (not sensitive) |
| 210 | + |
| 211 | + var headers7 = HTTPHeaders([:]) |
| 212 | + var headers8 = HTTPHeaders([:]) |
| 213 | + headers7.update(name: "Authorization", value: username + ":" + password) |
| 214 | + headers8.update(name: "Data", value: harmless) |
| 215 | + |
| 216 | + AF.request("http://example.com/", headers: headers7) // BAD [NOT DETECTED] |
| 217 | + AF.request("http://example.com/", headers: headers8) // GOOD (not sensitive) |
| 218 | +} |
0 commit comments