Skip to content

Commit 2c0bae4

Browse files
erik-kroghesbena
andauthored
Apply suggestions from code review
Co-Authored-By: Esben Sparre Andreasen <[email protected]>
1 parent 75b183b commit 2c0bae4

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

javascript/ql/src/semmle/javascript/Collections.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ abstract private class CollectionFlowStep extends DataFlow::AdditionalFlowStep {
8484
}
8585

8686
/**
87-
* A collection of predicates and clases for type-tracking collections.
87+
* Provides predicates and clases for type-tracking collections.
8888
*/
8989
module CollectionsTypeTracking {
9090
/**
@@ -220,9 +220,9 @@ private module CollectionDataFlow {
220220
* A call to the `set` method on a Map.
221221
*
222222
* If the key of the call to `set` has a known string value,
223-
* then the value will be saved into a pseudo-property corresponding to the known string value.
224-
* Otherwise the value will be saved into a pseudo-property corresponding to values with unknown keys.
225-
* The value will additionally be saved into a pseudo-property corresponding to all values.
223+
* then the value will be stored into a pseudo-property corresponding to the known string value.
224+
* Otherwise the value will be stored into a pseudo-property corresponding to values with unknown keys.
225+
* The value will additionally be stored into a pseudo-property corresponding to all values.
226226
*/
227227
class MapSet extends CollectionFlowStep, DataFlow::MethodCallNode {
228228
MapSet() { this.getMethodName() = "set" }

javascript/ql/src/semmle/javascript/dataflow/Configuration.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ module PseudoProperties {
611611
/**
612612
* Gets a pseudo-property for the location of map values, where the key is unknown.
613613
*/
614-
string mapValueUnknownKey() { result = pseudoProperty("unknownMapValue") }
614+
string mapValueUnknownKey() { result = pseudoProperty("mapValueUnknownKey") }
615615

616616
/**
617617
* Gets a pseudo-property for the location of all the values in a map.

javascript/ql/src/semmle/javascript/dataflow/internal/StepSummary.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class StepSummary extends TStepSummary {
6666
exists(string prop | this = CopyStep(prop) | result = "copy " + prop)
6767
or
6868
exists(string fromProp, string toProp | this = LoadStoreStep(fromProp, toProp) |
69-
result = "copy " + fromProp + " to " + toProp
69+
result = "load " + fromProp + " and store to " + toProp
7070
)
7171
}
7272
}

0 commit comments

Comments
 (0)