Skip to content

Commit 2e30f2d

Browse files
committed
Java: Fix QHelp & accept test output
Accept test output for changed alert message.
1 parent d3e6e59 commit 2e30f2d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

java/ql/src/experimental/Security/CWE/CWE-295/JxBrowserWithoutCertValidation.qhelp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ Versions smaller than 6.24 by default ignore any HTTPS certificate errors thereb
1111

1212
<recommendation>
1313
<p>Do either of these:
14-
<li>Update to version 6.24 or 7.x.x as these correctly reject certificate errors by default.</li>
15-
<li>Add a custom implementation of the <code>LoadHandler</code> interface whose <code>onCertificateError</code> method always returns <b>true</b> indicating that loading should be cancelled.
16-
Then use the <code>setLoadHandler</code> method with your custom <code>LoadHandler</code> on every <code>Browser</code> you use.</li>
14+
<ul>
15+
<li>Update to version 6.24 or 7.x.x as these correctly reject certificate errors by default.</li>
16+
<li>Add a custom implementation of the <code>LoadHandler</code> interface whose <code>onCertificateError</code> method always returns <b>true</b> indicating that loading should be cancelled.
17+
Then use the <code>setLoadHandler</code> method with your custom <code>LoadHandler</code> on every <code>Browser</code> you use.</li>
18+
</ul>
1719
</p>
1820
</recommendation>
1921

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
| JxBrowserWithoutCertValidationV6_23_1.java:17:27:17:39 | new Browser(...) | This JxBrowser instance allows man-in-the-middle attacks. |
1+
| JxBrowserWithoutCertValidationV6_23_1.java:17:27:17:39 | new Browser(...) | This JxBrowser instance may not check HTTPS certificates. |

0 commit comments

Comments
 (0)