C#: Fix default parameter value generation in case of error symbols

tamasvajk · tamasvajk · commit 31ac6442e8c3 · 2021-05-10T17:03:08.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expression.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expression.cs
@@ -170,7 +170,8 @@ private static bool ContainsPattern(SyntaxNode node) =>
         public static Expression? CreateGenerated(Context cx, IParameterSymbol parameter, IExpressionParentEntity parent,
             int childIndex, Extraction.Entities.Location location)
         {
-            if (!parameter.HasExplicitDefaultValue)
+            if (!parameter.HasExplicitDefaultValue ||
+                parameter.Type is IErrorTypeSymbol)
             {
                 return null;
             }

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,8 @@ private static bool ContainsPattern(SyntaxNode node) =>`
`170`	`170`	`public static Expression? CreateGenerated(Context cx, IParameterSymbol parameter, IExpressionParentEntity parent,`
`171`	`171`	`int childIndex, Extraction.Entities.Location location)`
`172`	`172`	`{`
`173`		`- if (!parameter.HasExplicitDefaultValue)`
	`173`	`+ if (!parameter.HasExplicitDefaultValue \|\|`
	`174`	`+ parameter.Type is IErrorTypeSymbol)`
`174`	`175`	`{`
`175`	`176`	`return null;`
`176`	`177`	`}`