|
| 1 | + |
| 2 | +// --- stubs --- |
| 3 | + |
| 4 | +struct URL |
| 5 | +{ |
| 6 | + init?(string: String) {} |
| 7 | +} |
| 8 | + |
| 9 | +struct Locale { |
| 10 | +} |
| 11 | + |
| 12 | +extension String : CVarArg { |
| 13 | + public var _cVarArgEncoding: [Int] { get { return [] } } |
| 14 | + |
| 15 | + init(contentsOf: URL) throws { self.init() } |
| 16 | + init(format: String, _ arguments: CVarArg...) { self.init() } |
| 17 | + init(format: String, arguments: [CVarArg]) { self.init() } |
| 18 | + init(format: String, locale: Locale?, _ args: CVarArg...) { self.init() } |
| 19 | + init(format: String, locale: Locale?, arguments: [CVarArg]) { self.init() } |
| 20 | + |
| 21 | + static func localizedStringWithFormat(_ format: String, _ arguments: CVarArg...) -> String { return "" } |
| 22 | +} |
| 23 | + |
| 24 | +class NSObject |
| 25 | +{ |
| 26 | +} |
| 27 | + |
| 28 | +class NSString : NSObject |
| 29 | +{ |
| 30 | + init(string aString: String) {} |
| 31 | + init(format: NSString, _ args: CVarArg...) {} |
| 32 | + |
| 33 | + class func localizedStringWithFormat(_ format: NSString, _ args: CVarArg...) {} |
| 34 | +} |
| 35 | + |
| 36 | +class NSMutableString : NSString |
| 37 | +{ |
| 38 | +} |
| 39 | + |
| 40 | +struct NSExceptionName { |
| 41 | + init(_ rawValue: String) {} |
| 42 | +} |
| 43 | + |
| 44 | +class NSException: NSObject |
| 45 | +{ |
| 46 | + class func raise(_ name: NSExceptionName, format: String, arguments argList: CVaListPointer) {} |
| 47 | +} |
| 48 | + |
| 49 | +func NSLog(_ format: String, _ args: CVarArg...) {} |
| 50 | + |
| 51 | +func NSLogv(_ format: String, _ args: CVaListPointer) {} |
| 52 | + |
| 53 | +// --- tests --- |
| 54 | + |
| 55 | +func MyLog(_ format: String, _ args: CVarArg...) { |
| 56 | + withVaList(args) { arglist in |
| 57 | + NSLogv(format, arglist) // BAD [NOT DETECTED] |
| 58 | + } |
| 59 | +} |
| 60 | + |
| 61 | +func tests() { |
| 62 | + let tainted = try! String(contentsOf: URL(string: "http://example.com")!) |
| 63 | + |
| 64 | + let a = String("abc") // GOOD: not a format string |
| 65 | + let b = String(tainted) // GOOD: not a format string |
| 66 | + |
| 67 | + let c = String(format: "abc") // GOOD: not tainted |
| 68 | + let d = String(format: tainted) // BAD |
| 69 | + let e = String(format: "%s", "abc") // GOOD: not tainted |
| 70 | + let f = String(format: "%s", tainted) // GOOD: format string itself is not tainted |
| 71 | + let g = String(format: tainted, "abc") // BAD |
| 72 | + let h = String(format: tainted, tainted) // BAD |
| 73 | + |
| 74 | + let i = String(format: tainted, arguments: []) // BAD |
| 75 | + let j = String(format: tainted, locale: nil) // BAD |
| 76 | + let k = String(format: tainted, locale: nil, arguments: []) // BAD |
| 77 | + let l = String.localizedStringWithFormat(tainted) // BAD |
| 78 | + |
| 79 | + let m = NSString(format: NSString(string: tainted), "abc") // BAD [NOT DETECTED] |
| 80 | + let n = NSString.localizedStringWithFormat(NSString(string: tainted)) // BAD [NOT DETECTED] |
| 81 | + |
| 82 | + var o = NSMutableString(format: NSString(string: tainted), "abc") // BAD [NOT DETECTED] |
| 83 | + var p = NSMutableString.localizedStringWithFormat(NSString(string: tainted)) // BAD [NOT DETECTED] |
| 84 | + |
| 85 | + NSLog("abc") // GOOD: not tainted |
| 86 | + NSLog(tainted) // BAD |
| 87 | + MyLog(tainted) // BAD [NOT DETECTED] |
| 88 | + |
| 89 | + NSException.raise(NSExceptionName("exception"), format: tainted, arguments: getVaList([])) // BAD |
| 90 | + |
| 91 | + let taintedVal = Int(tainted)! |
| 92 | + let taintedSan = "\(taintedVal)" |
| 93 | + let q = String(format: taintedSan) // GOOD: sufficiently sanitized |
| 94 | + |
| 95 | + let taintedVal2 = Int(tainted) ?? 0 |
| 96 | + let taintedSan2 = String(taintedVal2) |
| 97 | + let r = String(format: taintedSan2) // GOOD: sufficiently sanitized |
| 98 | +} |
0 commit comments