C++/C#: Change dump of unmodeled use to m?

This is kind of inconsequential on its own, but will make the test diffs easier to understand once the next commit removes `UnmodeledDefinition`.

Author: Dave Bartolomeo

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Operand.qll

@@ -147,7 +147,18 @@ class Operand extends TOperand {
    * For example: `this:r3_5`
    */
   final string getDumpString() {
-    result = getDumpLabel() + getInexactSpecifier() + getAnyDef().getResultId()
+    result = getDumpLabel() + getInexactSpecifier() + getDefinitionId()
+  }
+
+  /**
+   * Gets a string containing the identifier of the definition of this use, or `m?` if the
+   * definition is not modeled in SSA.
+   */
+  private string getDefinitionId() {
+    exists(Instruction def |
+      def = getAnyDef() and
+      if def.isResultModeled() then result = def.getResultId() else result = "m?"
+    )
   }
 
   /**

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Operand.qll

@@ -147,7 +147,18 @@ class Operand extends TOperand {
    * For example: `this:r3_5`
    */
   final string getDumpString() {
-    result = getDumpLabel() + getInexactSpecifier() + getAnyDef().getResultId()
+    result = getDumpLabel() + getInexactSpecifier() + getDefinitionId()
+  }
+
+  /**
+   * Gets a string containing the identifier of the definition of this use, or `m?` if the
+   * definition is not modeled in SSA.
+   */
+  private string getDefinitionId() {
+    exists(Instruction def |
+      def = getAnyDef() and
+      if def.isResultModeled() then result = def.getResultId() else result = "m?"
+    )
   }
 
   /**

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Operand.qll

@@ -147,7 +147,18 @@ class Operand extends TOperand {
    * For example: `this:r3_5`
    */
   final string getDumpString() {
-    result = getDumpLabel() + getInexactSpecifier() + getAnyDef().getResultId()
+    result = getDumpLabel() + getInexactSpecifier() + getDefinitionId()
+  }
+
+  /**
+   * Gets a string containing the identifier of the definition of this use, or `m?` if the
+   * definition is not modeled in SSA.
+   */
+  private string getDefinitionId() {
+    exists(Instruction def |
+      def = getAnyDef() and
+      if def.isResultModeled() then result = def.getResultId() else result = "m?"
+    )
   }
 
   /**

cpp/ql/test/library-tests/ir/ir/raw_ir.expected

@@ -147,7 +147,18 @@ class Operand extends TOperand {
    * For example: `this:r3_5`
    */
   final string getDumpString() {
-    result = getDumpLabel() + getInexactSpecifier() + getAnyDef().getResultId()
+    result = getDumpLabel() + getInexactSpecifier() + getDefinitionId()
+  }
+
+  /**
+   * Gets a string containing the identifier of the definition of this use, or `m?` if the
+   * definition is not modeled in SSA.
+   */
+  private string getDefinitionId() {
+    exists(Instruction def |
+      def = getAnyDef() and
+      if def.isResultModeled() then result = def.getResultId() else result = "m?"
+    )
   }
 
   /**

cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_ir.expected

@@ -147,7 +147,18 @@ class Operand extends TOperand {
    * For example: `this:r3_5`
    */
   final string getDumpString() {
-    result = getDumpLabel() + getInexactSpecifier() + getAnyDef().getResultId()
+    result = getDumpLabel() + getInexactSpecifier() + getDefinitionId()
+  }
+
+  /**
+   * Gets a string containing the identifier of the definition of this use, or `m?` if the
+   * definition is not modeled in SSA.
+   */
+  private string getDefinitionId() {
+    exists(Instruction def |
+      def = getAnyDef() and
+      if def.isResultModeled() then result = def.getResultId() else result = "m?"
+    )
   }
 
   /**