Skip to content

Commit 36b0ab1

Browse files
erik-kroghesbena
andauthored
Apply suggestions from code review
Co-authored-by: Esben Sparre Andreasen <[email protected]>
1 parent a28a36a commit 36b0ab1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

javascript/ql/src/semmle/javascript/PackageExports.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ PackageJSON getTopmostPackageJSON() {
4242
* Gets a value exported by the main module from one of the topmost `package.json` files (see `getTopmostPackageJSON`).
4343
* The value is either directly the `module.exports` value, a nested property of `module.exports`, or a method on an exported class.
4444
*/
45-
DataFlow::Node getAValueExportedByPackage() {
45+
private DataFlow::Node getAValueExportedByPackage() {
4646
result = getAnExportFromModule(getTopmostPackageJSON().getMainModule())
4747
or
4848
result = getAValueExportedByPackage().(DataFlow::PropWrite).getRhs()
@@ -72,7 +72,7 @@ DataFlow::Node getAValueExportedByPackage() {
7272
)
7373
or
7474
// *****
75-
// Various standard library methods for transforming exported objects.
75+
// Common styles of transforming exported objects.
7676
// *****
7777
//
7878
// Object.defineProperties
@@ -96,7 +96,7 @@ DataFlow::Node getAValueExportedByPackage() {
9696
.getAReturn()
9797
)
9898
or
99-
// Object.assign
99+
// Object.assign and friends
100100
exists(ExtendCall assign |
101101
getAValueExportedByPackage() = [assign, assign.getDestinationOperand()] and
102102
result = assign.getASourceOperand()
@@ -113,7 +113,7 @@ DataFlow::Node getAValueExportedByPackage() {
113113
result = map.getReceiver()
114114
)
115115
or
116-
// Object.{fromEntries, freeze, entries, values}
116+
// Object.{fromEntries, freeze, seal, entries, values}
117117
exists(DataFlow::MethodCallNode freeze |
118118
freeze =
119119
DataFlow::globalVarRef("Object")

0 commit comments

Comments
 (0)