Ruby: Cache some barrier guard predicates

hmac · hmac · commit 376d4e03a144 · 2022-11-18T18:17:02.000+13:00
diff --git a/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll b/ruby/ql/lib/codeql/ruby/dataflow/BarrierGuards.qll
@@ -9,6 +9,7 @@ private import codeql.ruby.ast.internal.Constant
 private import codeql.ruby.InclusionTests
 private import codeql.ruby.ast.internal.Literal
 
+cached
 private predicate stringConstCompare(CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch) {
   exists(CfgNodes::ExprNodes::ComparisonOperationCfgNode c |
     c = guard and
@@ -102,6 +103,7 @@ deprecated class StringConstCompare extends DataFlow::BarrierGuard,
   }
 }
 
+cached
 private predicate stringConstArrayInclusionCall(
   CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch
 ) {

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ private import codeql.ruby.ast.internal.Constant`
`9`	`9`	`private import codeql.ruby.InclusionTests`
`10`	`10`	`private import codeql.ruby.ast.internal.Literal`
`11`	`11`
	`12`	`+cached`
`12`	`13`	`private predicate stringConstCompare(CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch) {`
`13`	`14`	`exists(CfgNodes::ExprNodes::ComparisonOperationCfgNode c \|`
`14`	`15`	`c = guard and`
`@@ -102,6 +103,7 @@ deprecated class StringConstCompare extends DataFlow::BarrierGuard,`
`102`	`103`	`}`
`103`	`104`	`}`
`104`	`105`
	`106`	`+cached`
`105`	`107`	`private predicate stringConstArrayInclusionCall(`
`106`	`108`	`CfgNodes::AstCfgNode guard, CfgNode testedNode, boolean branch`
`107`	`109`	`) {`