Python: Modernise RatioOfDefinitions

RasmusWL · RasmusWL · commit 37cfb5400deb · 2020-06-10T11:51:41.000+02:00
diff --git a/python/ql/src/analysis/RatioOfDefinitions.ql b/python/ql/src/analysis/RatioOfDefinitions.ql
@@ -7,7 +7,7 @@ import DefinitionTracking
 
 predicate want_to_have_definition(Expr e) {
     /* not builtin object like len, tuple, etc. */
-    not exists(Object cobj | e.refersTo(cobj) and cobj.isC()) and
+    not exists(Value builtin | e.pointsTo(builtin) and builtin.isBuiltin()) and
     (
         e instanceof Name and e.(Name).getCtx() instanceof Load
         or

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ import DefinitionTracking`
`7`	`7`
`8`	`8`	`predicate want_to_have_definition(Expr e) {`
`9`	`9`	`/* not builtin object like len, tuple, etc. */`
`10`		`- not exists(Object cobj \| e.refersTo(cobj) and cobj.isC()) and`
	`10`	`+ not exists(Value builtin \| e.pointsTo(builtin) and builtin.isBuiltin()) and`
`11`	`11`	`(`
`12`	`12`	`e instanceof Name and e.(Name).getCtx() instanceof Load`
`13`	`13`	`or`