Update swift/ql/test/library-tests/dataflow/dataflow/FlowConfig.qll

atorralba · geoffw0 · web-flow · commit 3973e1ce04c8 · 2022-10-24T11:37:51.000+02:00
Co-authored-by: Geoffrey White &lt;40627776+geoffw0@users.noreply.github.com&gt;
diff --git a/swift/ql/test/library-tests/dataflow/dataflow/FlowConfig.qll b/swift/ql/test/library-tests/dataflow/dataflow/FlowConfig.qll
@@ -25,7 +25,7 @@ class TestConfiguration extends DataFlow::Configuration {
 
 private class TestSummaries extends SummaryModelCsv {
   override predicate row(string row) {
-    // dumb model to allow testing flow through optional chaining (`x?.signum()`)
+    // model to allow data flow through `signum()` as though it were an identity function, for the benefit of testing flow through optional chaining (`x?.`).
     row = ";Int;true;signum();;;Argument[-1];ReturnValue;value"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class TestConfiguration extends DataFlow::Configuration {`
`25`	`25`
`26`	`26`	`private class TestSummaries extends SummaryModelCsv {`
`27`	`27`	`override predicate row(string row) {`
`28`		- // dumb model to allow testing flow through optional chaining (`x?.signum()`)
	`28`	+ // model to allow data flow through `signum()` as though it were an identity function, for the benefit of testing flow through optional chaining (`x?.`).
`29`	`29`	`row = ";Int;true;signum();;;Argument[-1];ReturnValue;value"`
`30`	`30`	`}`
`31`	`31`	`}`