Simplify MissingCallTarget for calli

tamasvajk · tamasvajk · commit 3b82abd7c711 · 2021-03-02T09:21:24.000+01:00
diff --git a/csharp/ql/src/semmle/code/cil/ConsistencyChecks.qll b/csharp/ql/src/semmle/code/cil/ConsistencyChecks.qll
@@ -83,7 +83,7 @@ class MissingCallTarget extends InstructionViolation {
     exists(Call c | c = instruction |
       count(c.getTarget()) != 1 and not c instanceof Opcodes::Calli
       or
-      count(c.(Opcodes::Calli).getTargetType()) != 1 and c instanceof Opcodes::Calli
+      count(c.(Opcodes::Calli).getTargetType()) != 1
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ class MissingCallTarget extends InstructionViolation {`
`83`	`83`	`exists(Call c \| c = instruction \|`
`84`	`84`	`count(c.getTarget()) != 1 and not c instanceof Opcodes::Calli`
`85`	`85`	`or`
`86`		`- count(c.(Opcodes::Calli).getTargetType()) != 1 and c instanceof Opcodes::Calli`
	`86`	`+ count(c.(Opcodes::Calli).getTargetType()) != 1`
`87`	`87`	`)`
`88`	`88`	`}`
`89`	`89`