Skip to content

Commit 3d0ac53

Browse files
MathiasVPjbj
andauthored
Apply suggestions from code review
Co-Authored-By: Jonas Jensen <[email protected]>
1 parent a2fbe9e commit 3d0ac53

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpp/ql/src/Critical/Negativity.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ predicate errorCondition(Variable v, Expr cond) {
129129
* - `cond` checks that `v` is not equal to `-1`, or
130130
* - `cond` checks that `v` is greater than or equal than `0`, or
131131
* - `cond` checks that `v` is greater than `-1`, or
132-
* - `cond` checks that `v` is not some common success value (see `errorCondition`).
132+
* - `cond` checks that `v` is not some common error value (see `errorCondition`).
133133
*/
134134
predicate successCondition(Variable v, Expr cond) {
135135
exists(NEExpr ne |
@@ -198,7 +198,7 @@ predicate checkedError(Variable v, ControlFlowNode n) {
198198

199199
/**
200200
* Holds if the current value of the variable `v` at control-flow node
201-
* `n` may have been checked against a common set of *error* values.
201+
* `n` may have been checked against a common set of *success* values.
202202
*/
203203
predicate checkedSuccess(Variable v, ControlFlowNode n) {
204204
successSuccessor(v, n)

0 commit comments

Comments
 (0)