Skip to content

Commit 3d9bbd7

Browse files
committed
ReDoS: fix potential bad mistake caught by QL-for-QL
1 parent b071d35 commit 3d9bbd7

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

shared/regex/codeql/regex/nfa/SuperlinearBackTracking.qll

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,9 +390,11 @@ module Make<RegexTreeViewSig TreeImpl> {
390390
getStartTuple(pivot, succ) = getARelevantStateTuple(pivot, succ)
391391
} or
392392
Step(TTrace prev, StateTuple nextTuple) {
393-
exists(StateTuple prevTuple, State pivot, State succ |
394-
prev = Nil(pivot, succ) and
395-
prevTuple = getStartTuple(pivot, succ)
393+
exists(StateTuple prevTuple |
394+
exists(State pivot, State succ |
395+
prev = Nil(pivot, succ) and
396+
prevTuple = getStartTuple(pivot, succ)
397+
)
396398
or
397399
prev = Step(_, prevTuple)
398400
|

0 commit comments

Comments
 (0)