Merge pull request github#5154 from smowton/smowton/admin/deprecate-old-maven-predicate-names

Java: Re-introduce deprecated versions of old Maven predicate names

Author: smowton

java/ql/src/semmle/code/xml/MavenPom.qll

@@ -428,11 +428,21 @@ class MavenRepoJar extends File {
     )
   }
 
+  /**
+   * DEPRECATED: name changed to `getGroupId` for consistent use of camel-case.
+   */
+  deprecated string getGroupID() { result = getGroupId() }
+
   /**
    * Gets the `artifactId` of this jar.
    */
   string getArtifactId() { result = getParentContainer().getParentContainer().getBaseName() }
 
+  /**
+   * DEPRECATED: name changed to `getArtifactId` for consistent casing and consistent spelling with Maven.
+   */
+  deprecated string getArtefactID() { result = getArtifactId() }
+
   /**
    * Gets the artifact version string of this jar.
    */
@@ -446,6 +456,11 @@ class MavenRepoJar extends File {
     pom.getArtifact().getValue() = getArtifactId()
   }
 
+  /**
+   * DEPRECATED: name changed to `artifactMatches` for consistent spelling with Maven.
+   */
+  deprecated predicate artefactMatches(ProtoPom pom) { artifactMatches(pom) }
+
   /**
    * Holds if this jar is both an artifact for the POM, and has a version string that matches the POM
    * version string. Only soft and hard version matches are supported.