Fix conversion operator stubbing + reduce skipped ctor noise in stubs

Author: tamasvajk

csharp/ql/src/Stubs/Stubs.qll

@@ -744,11 +744,9 @@ private string stubMember(Member m, Assembly assembly) {
           stubParameters(m) + ")" + stubTypeParametersConstraints(m) + stubImplementation(m) + ";\n"
     else result = "    // Stub generator skipped method: " + m.getName() + "\n"
   else
-    if m instanceof Operator
+    if m instanceof Operator and not m instanceof ConversionOperator
     then
-      if
-        not m.getDeclaringType() instanceof Enum and
-        not m instanceof ConversionOperator
+      if not m.getDeclaringType() instanceof Enum
       then
         result =
           "    " + stubModifiers(m) + stubClassName(m.(Operator).getReturnType()) + " operator " +
@@ -774,17 +772,17 @@ private string stubMember(Member m, Assembly assembly) {
           else
             if m instanceof Constructor
             then
-              if
-                not m.getDeclaringType() instanceof Enum and
-                (
+              if m.getDeclaringType() instanceof Enum
+              then result = ""
+              else
+                if
                   not m.getDeclaringType() instanceof StructEx or
                   m.(Constructor).getNumberOfParameters() > 0
-                )
-              then
-                result =
-                  "    " + stubModifiers(m) + m.getName() + "(" + stubParameters(m) + ")" +
-                    stubConstructorInitializer(m) + " => throw null;\n"
-              else result = "    // Stub generator skipped constructor \n"
+                then
+                  result =
+                    "    " + stubModifiers(m) + m.getName() + "(" + stubParameters(m) + ")" +
+                      stubConstructorInitializer(m) + " => throw null;\n"
+                else result = "    // Stub generator skipped constructor \n"
             else
               if m instanceof Indexer
               then

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Components.Web.cs

@@ -268,7 +268,6 @@ public class NavLink : Microsoft.AspNetCore.Components.ComponentBase, System.IDi
                 public enum NavLinkMatch
                 {
                     All,
-                    // Stub generator skipped constructor 
                     Prefix,
                 }
 

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Components.cs

@@ -325,7 +325,7 @@ public struct MarkupString
                 // Stub generator skipped constructor 
                 public override string ToString() => throw null;
                 public string Value { get => throw null; }
-                // Stub generator skipped operator: explicit conversion
+                public static explicit operator Microsoft.AspNetCore.Components.MarkupString(string value) => throw null;
             }
 
             // Generated from `Microsoft.AspNetCore.Components.NavigationException` in `Microsoft.AspNetCore.Components, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60`
@@ -528,7 +528,6 @@ public enum RenderTreeEditType
                     PrependFrame,
                     RemoveAttribute,
                     RemoveFrame,
-                    // Stub generator skipped constructor 
                     SetAttribute,
                     StepIn,
                     StepOut,
@@ -575,7 +574,6 @@ public enum RenderTreeFrameType
                     Markup,
                     None,
                     Region,
-                    // Stub generator skipped constructor 
                     Text,
                 }
 

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Connections.Abstractions.cs

@@ -134,7 +134,6 @@ public class FileHandleEndPoint : System.Net.EndPoint
             public enum FileHandleType
             {
                 Auto,
-                // Stub generator skipped constructor 
                 Pipe,
                 Tcp,
             }
@@ -173,7 +172,6 @@ public enum TransferFormat
             {
                 Binary,
                 Text,
-                // Stub generator skipped constructor 
             }
 
             // Generated from `Microsoft.AspNetCore.Connections.UriEndPoint` in `Microsoft.AspNetCore.Connections.Abstractions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60`

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.CookiePolicy.cs

@@ -67,7 +67,6 @@ public class DeleteCookieContext
             public enum HttpOnlyPolicy
             {
                 Always,
-                // Stub generator skipped constructor 
                 None,
             }
 

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Cryptography.KeyDerivation.cs

@@ -20,7 +20,6 @@ public enum KeyDerivationPrf
                     HMACSHA1,
                     HMACSHA256,
                     HMACSHA512,
-                    // Stub generator skipped constructor 
                 }
 
             }

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.DataProtection.cs

@@ -118,7 +118,6 @@ public enum EncryptionAlgorithm
                     AES_192_GCM,
                     AES_256_CBC,
                     AES_256_GCM,
-                    // Stub generator skipped constructor 
                 }
 
                 // Generated from `Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor` in `Microsoft.AspNetCore.DataProtection, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60`
@@ -146,7 +145,6 @@ public enum ValidationAlgorithm
                 {
                     HMACSHA256,
                     HMACSHA512,
-                    // Stub generator skipped constructor 
                 }
 
                 namespace ConfigurationModel
@@ -458,7 +456,6 @@ public class CertificateXmlEncryptor : Microsoft.AspNetCore.DataProtection.XmlEn
                 [System.Flags]
                 public enum DpapiNGProtectionDescriptorFlags
                 {
-                    // Stub generator skipped constructor 
                     MachineKey,
                     NamedDescriptor,
                     None,

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Http.Abstractions.cs

@@ -176,7 +176,6 @@ public class CookieBuilder
             public enum CookieSecurePolicy
             {
                 Always,
-                // Stub generator skipped constructor 
                 None,
                 SameAsRequest,
             }
@@ -445,8 +444,8 @@ public struct PathString : System.IEquatable<Microsoft.AspNetCore.Http.PathStrin
                 public override string ToString() => throw null;
                 public string ToUriComponent() => throw null;
                 public string Value { get => throw null; }
-                // Stub generator skipped operator: implicit conversion
-                // Stub generator skipped operator: implicit conversion
+                public static implicit operator string(Microsoft.AspNetCore.Http.PathString path) => throw null;
+                public static implicit operator Microsoft.AspNetCore.Http.PathString(string s) => throw null;
             }
 
             // Generated from `Microsoft.AspNetCore.Http.QueryString` in `Microsoft.AspNetCore.Http.Abstractions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60`

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Http.Connections.Common.cs

@@ -20,7 +20,6 @@ public class AvailableTransport
                 [System.Flags]
                 public enum HttpTransportType
                 {
-                    // Stub generator skipped constructor 
                     LongPolling,
                     None,
                     ServerSentEvents,

csharp/ql/test/resources/stubs/frameworks/Microsoft.AspNetCore.App/Microsoft.AspNetCore.Http.Features.cs

@@ -108,7 +108,6 @@ public enum SameSiteMode
             {
                 Lax,
                 None,
-                // Stub generator skipped constructor 
                 Strict,
                 Unspecified,
             }
@@ -165,7 +164,6 @@ public enum HttpsCompressionMode
                     Compress,
                     Default,
                     DoNotCompress,
-                    // Stub generator skipped constructor 
                 }
 
                 // Generated from `Microsoft.AspNetCore.Http.Features.IFeatureCollection` in `Microsoft.AspNetCore.Http.Features, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60`