Python: ObjectAPI to ValueAPI: ReturnValueIgnored: Adds prototype version of getAnInferredReturnType

Author: BekaValentine

python/ql/src/Functions/ReturnValueIgnored.ql

@@ -42,7 +42,7 @@ predicate returns_meaningful_value(FunctionValue f) {
       or
       /* Is f a builtin function that returns something other than None?
        * Ignore __import__ as it is often called purely for side effects */
-      f.isBuiltin() and f.getAnInferredReturnType() != theNoneType() and not f.getName() = "__import__"
+      f.isBuiltin() and f.getAnInferredReturnType() != ClassValue::nonetype() and not f.getName() = "__import__"
     )
 }
 

python/ql/src/semmle/python/objects/ObjectAPI.qll

@@ -514,6 +514,12 @@ abstract class FunctionValue extends CallableValue {
     predicate isOverriddenMethod() {
         exists(Value f | f.overrides(this))
     }
+
+    /** Gets a class that this function may return */
+    ClassValue getAnInferredReturnType() {
+        //result = this.(BuiltinCallable).getAReturnType()
+        result = this.getScope().getAReturnValueFlowNode().pointsTo().getClass()
+    }
 }
 
 /** Class representing Python functions */