JS: Fix perf issue in forwardsParameter

asgerf · asgerf · commit 43ca8ea5f795 · 2021-04-20T15:15:12.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
@@ -1693,7 +1693,7 @@ module DataFlow {
       parameter.flowsTo(call.getArgument(i))
       or
       parameter.isRestParameter() and
-      parameter.flowsTo(call.asExpr().(CallExpr).getArgument(i).(SpreadElement).getOperand().flow())
+      parameter.flowsTo(call.getASpreadArgument())
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1693,7 +1693,7 @@ module DataFlow {`
`1693`	`1693`	`parameter.flowsTo(call.getArgument(i))`
`1694`	`1694`	`or`
`1695`	`1695`	`parameter.isRestParameter() and`
`1696`		`- parameter.flowsTo(call.asExpr().(CallExpr).getArgument(i).(SpreadElement).getOperand().flow())`
	`1696`	`+ parameter.flowsTo(call.getASpreadArgument())`
`1697`	`1697`	`)`
`1698`	`1698`	`}`
`1699`	`1699`