C++: Make Declaration not abstract

jbj · jbj · commit 448bd2be8725 · 2020-04-22T17:34:18.000+02:00
It looks like this change will stop `SignedOverflowCheck.ql` from
needlessly re-evaluating several cached stages.
diff --git a/cpp/ql/src/semmle/code/cpp/Declaration.qll b/cpp/ql/src/semmle/code/cpp/Declaration.qll
@@ -25,7 +25,7 @@ private import semmle.code.cpp.internal.QualifiedName as Q
  * `DeclarationEntry`, because they always have a unique source location.
  * `EnumConstant` and `FriendDecl` are both examples of this.
  */
-abstract class Declaration extends Locatable, @declaration {
+class Declaration extends Locatable, @declaration {
   /**
    * Gets the innermost namespace which contains this declaration.
    *

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ private import semmle.code.cpp.internal.QualifiedName as Q`
`25`	`25`	* `DeclarationEntry`, because they always have a unique source location.
`26`	`26`	* `EnumConstant` and `FriendDecl` are both examples of this.
`27`	`27`	`*/`
`28`		`-abstract class Declaration extends Locatable, @declaration {`
	`28`	`+class Declaration extends Locatable, @declaration {`
`29`	`29`	`/**`
`30`	`30`	`* Gets the innermost namespace which contains this declaration.`
`31`	`31`	`*`