Apply suggestions from code review

Note value-preserving functions can't be constructors

Co-authored-by: Anders Schack-Mulligen <[email protected]>

Author: smowton

java/ql/src/semmle/code/java/dataflow/FlowSteps.qll

@@ -21,24 +21,24 @@ private module Frameworks {
 }
 
 /**
- * A method or constructor that returns the exact value of one of its parameters or the qualifier.
+ * A method that returns the exact value of one of its parameters or the qualifier.
  *
  * Extend this class and override `returnsValue` to add additional value-preserving steps through a
  * method that should be added to the basic local flow step relation.
  *
  * These steps will be visible for all global data-flow purposes, as well as via
  * `DataFlow::Node.getASuccessor` and other related functions exposing intraprocedural dataflow.
  */
-abstract class ValuePreservingCallable extends Callable {
+abstract class ValuePreservingMethod extends Method {
   /**
-   * Holds if this callable returns precisely the value passed into argument `arg`.
+   * Holds if this method returns precisely the value passed into argument `arg`.
    * `arg` is a parameter index, or is -1 to indicate the qualifier.
    */
   abstract predicate returnsValue(int arg);
 }
 
 /**
- * A method or constructor that returns the exact value of its qualifier (e.g., `return this;`)
+ * A method that returns the exact value of its qualifier (e.g., `return this;`)
  *
  * Extend this class and override `returnsValue` to add additional value-preserving steps through a
  * method that should be added to the basic local flow step relation.