Address review comments

Author: tamasvajk

csharp/ql/test/library-tests/controlflow/graph/BasicBlock.ql

@@ -2,5 +2,4 @@ import csharp
 import Common
 
 from SourceBasicBlock bb
-where not bb.getFirstNode().getElement().fromLibrary()
 select bb.getFirstNode(), bb.getLastNode(), bb.length()

csharp/ql/test/library-tests/controlflow/graph/Common.qll

@@ -11,9 +11,15 @@ class SourceControlFlowElement extends ControlFlowElement {
 }
 
 class SourceControlFlowNode extends ControlFlow::Node {
-  SourceControlFlowNode() { not this.getLocation().getFile() instanceof StubFile }
+  SourceControlFlowNode() {
+    not this.getLocation().getFile() instanceof StubFile and
+    not this.getLocation().getFile().fromLibrary()
+  }
 }
 
 class SourceBasicBlock extends ControlFlow::BasicBlock {
-  SourceBasicBlock() { not this.getLocation().getFile() instanceof StubFile }
+  SourceBasicBlock() {
+    not this.getLocation().getFile() instanceof StubFile and
+    not this.getLocation().getFile().fromLibrary()
+  }
 }

csharp/ql/test/library-tests/controlflow/graph/Dominance.ql

@@ -1,25 +1,18 @@
 import csharp
 import Common
 
-/** Holds if `node` is not from a library. */
-private predicate isSourceBased(SourceControlFlowNode node) { not node.getElement().fromLibrary() }
-
 query predicate dominance(SourceControlFlowNode dom, SourceControlFlowNode node) {
-  isSourceBased(dom) and
   dom.strictlyDominates(node) and
   dom.getASuccessor() = node
 }
 
 query predicate postDominance(SourceControlFlowNode dom, SourceControlFlowNode node) {
-  isSourceBased(dom) and
   dom.strictlyPostDominates(node) and
   dom.getAPredecessor() = node
 }
 
-query predicate blockDominance(SourceBasicBlock dom, SourceBasicBlock bb) {
-  isSourceBased(dom.getFirstNode()) and dom.dominates(bb)
-}
+query predicate blockDominance(SourceBasicBlock dom, SourceBasicBlock bb) { dom.dominates(bb) }
 
 query predicate postBlockDominance(SourceBasicBlock dom, SourceBasicBlock bb) {
-  isSourceBased(dom.getFirstNode()) and dom.postDominates(bb)
+  dom.postDominates(bb)
 }

csharp/ql/test/library-tests/controlflow/graph/NodeGraph.ql

@@ -4,7 +4,6 @@ import Common
 query predicate edges(
   SourceControlFlowNode node, SourceControlFlowNode successor, string attr, string val
 ) {
-  not node.getElement().fromLibrary() and
   exists(ControlFlow::SuccessorType t | successor = node.getASuccessorByType(t) |
     attr = "semmle.label" and
     val = t.toString()