Use concise API

luchua-bc · luchua-bc · commit 502cf38fccef · 2021-03-03T14:07:43.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-1004/SensitiveCookieNotHttpOnly.ql b/java/ql/src/experimental/Security/CWE/CWE-1004/SensitiveCookieNotHttpOnly.ql
@@ -48,9 +48,8 @@ class SensitiveCookieNameExpr extends Expr {
       ClassInstanceExpr cie // new Cookie("jwt_token", token)
     |
       (
-        cie.getConstructor().getDeclaringType().hasQualifiedName("javax.servlet.http", "Cookie") or
-        cie.getConstructor()
-            .getDeclaringType()
+        cie.getConstructedType().hasQualifiedName("javax.servlet.http", "Cookie") or
+        cie.getConstructedType()
             .getASupertype*()
             .hasQualifiedName(["javax.ws.rs.core", "jakarta.ws.rs.core"], "Cookie")
       ) and

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,8 @@ class SensitiveCookieNameExpr extends Expr {`
`48`	`48`	`ClassInstanceExpr cie // new Cookie("jwt_token", token)`
`49`	`49`	`\|`
`50`	`50`	`(`
`51`		`- cie.getConstructor().getDeclaringType().hasQualifiedName("javax.servlet.http", "Cookie") or`
`52`		`- cie.getConstructor()`
`53`		`- .getDeclaringType()`
	`51`	`+ cie.getConstructedType().hasQualifiedName("javax.servlet.http", "Cookie") or`
	`52`	`+ cie.getConstructedType()`
`54`	`53`	`.getASupertype*()`
`55`	`54`	`.hasQualifiedName(["javax.ws.rs.core", "jakarta.ws.rs.core"], "Cookie")`
`56`	`55`	`) and`