Skip to content

Commit 576a872

Browse files
committed
C++: Address review comments.
1 parent fef824c commit 576a872

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/ql/src/semmle/code/cpp/models/implementations/Accept.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ private class Accept extends ArrayFunction, AliasFunction, TaintFunction, SideEf
1919
bufParam = 1 and countParam = 2
2020
}
2121

22-
override predicate hasArrayInput(int bufParam) { bufParam = [1, 2] }
22+
override predicate hasArrayInput(int bufParam) { bufParam = 1 }
2323

24-
override predicate hasArrayOutput(int bufParam) { bufParam = [1, 2] }
24+
override predicate hasArrayOutput(int bufParam) { bufParam = 1 }
2525

2626
override predicate parameterNeverEscapes(int index) { exists(this.getParameter(index)) }
2727

cpp/ql/src/semmle/code/cpp/models/implementations/Poll.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ private class Poll extends ArrayFunction, AliasFunction, TaintFunction, SideEffe
1919
bufParam = 0 and countParam = 1
2020
}
2121

22-
override predicate hasArrayInput(int bufParam) {
23-
getParameter(bufParam).getUnspecifiedType() instanceof PointerType
24-
}
22+
override predicate hasArrayInput(int bufParam) { bufParam = 0 }
2523

2624
override predicate hasArrayOutput(int bufParam) { bufParam = 0 }
2725

@@ -41,7 +39,9 @@ private class Poll extends ArrayFunction, AliasFunction, TaintFunction, SideEffe
4139
}
4240

4341
override predicate hasSpecificReadSideEffect(ParameterIndex i, boolean buffer) {
44-
getParameter(i).getUnspecifiedType() instanceof PointerType and buffer = true
42+
i = 0 and buffer = true
43+
or
44+
this.hasGlobalName("ppoll") and i = [2, 3] and buffer = false
4545
}
4646

4747
override predicate hasOnlySpecificReadSideEffects() { any() }

0 commit comments

Comments
 (0)