Skip to content

Commit 583d088

Browse files
committed
delete tomcat-embed-core stub, update the ServletGetMethod class
1 parent 5d05e4d commit 583d088

File tree

11 files changed

+1
-421
lines changed

11 files changed

+1
-421
lines changed

java/ql/src/experimental/Security/CWE/CWE-352/JsonpInjectionLib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ abstract class RequestGetMethod extends Method {
2121

2222
/** Override method of `doGet` of `Servlet` subclass. */
2323
private class ServletGetMethod extends RequestGetMethod {
24-
ServletGetMethod() { isServletRequestMethod(this) and m.getName() = "doGet" }
24+
ServletGetMethod() { isServletRequestMethod(this) and this.getName() = "doGet" }
2525
}
2626

2727
/** The method of SpringController class processing `get` request. */

java/ql/src/semmle/code/java/frameworks/Servlets.qll

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,3 @@ predicate isDoFilterMethod(Method m) {
361361
m.getParameter(1).getType() instanceof ServletResponse and
362362
m.getParameter(2).getType() instanceof FilterChain
363363
}
364-
365-
/** Holds if `m` is a method of some override of `HttpServlet.doGet`. */
366-
predicate isGetServletMethod(Method m) {
367-
isServletRequestMethod(m) and m.getName() = "doGet"
368-
}
369-
370-
/** The `doGet` method of `HttpServlet`. */
371-
class DoGetServletMethod extends Method {
372-
DoGetServletMethod() { isGetServletMethod(this) }
373-
}

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/Filter.java

Lines changed: 0 additions & 13 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/FilterChain.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/FilterConfig.java

Lines changed: 0 additions & 3 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/ServletException.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/ServletRequest.java

Lines changed: 0 additions & 87 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/ServletResponse.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/annotation/WebServlet.java

Lines changed: 0 additions & 30 deletions
This file was deleted.

java/ql/test/stubs/tomcat-embed-core-9.0.41/javax/servlet/http/HttpServletRequest.java

Lines changed: 0 additions & 116 deletions
This file was deleted.

0 commit comments

Comments
 (0)