Skip to content

Commit 58aa25d

Browse files
committed
Fix QLDocs
1 parent 7dbdba2 commit 58aa25d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

java/ql/src/semmle/code/java/security/JndiInjection.qll

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private class UnsafeSearchControlsSink extends JndiInjectionSink {
6262
}
6363

6464
/**
65-
* Tainted value passed to env `Hashtable` as the provider URL, i.e.
65+
* Tainted value passed to env `Hashtable` as the provider URL by calling
6666
* `env.put(Context.PROVIDER_URL, tainted)` or `env.setProperty(Context.PROVIDER_URL, tainted)`.
6767
*/
6868
private class ProviderUrlJndiInjectionSink extends JndiInjectionSink, DataFlow::ExprNode {
@@ -231,7 +231,7 @@ private class DefaultJndiInjectionAdditionalTaintStep extends JndiInjectionAddit
231231

232232
/**
233233
* Holds if `n1` to `n2` is a dataflow step that converts between `String` and `CompositeName` or
234-
* `CompoundName`, i.e. `new CompositeName(tainted)` or `new CompoundName(tainted)`.
234+
* `CompoundName` by calling `new CompositeName(tainted)` or `new CompoundName(tainted)`.
235235
*/
236236
private predicate nameStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
237237
exists(ConstructorCall cc |
@@ -245,7 +245,7 @@ private predicate nameStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
245245

246246
/**
247247
* Holds if `n1` to `n2` is a dataflow step that converts between `String` and `CompositeName` or
248-
* `CompoundName`, i.e. `new CompositeName().add(tainted)` or `new CompoundName().add(tainted)`.
248+
* `CompoundName` by calling `new CompositeName().add(tainted)` or `new CompoundName().add(tainted)`.
249249
*/
250250
private predicate nameAddStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
251251
exists(Method m, MethodAccess ma |
@@ -262,8 +262,8 @@ private predicate nameAddStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
262262
}
263263

264264
/**
265-
* Holds if `n1` to `n2` is a dataflow step that converts between `String` and `JMXServiceURL`,
266-
* i.e. `new JMXServiceURL(tainted)`.
265+
* Holds if `n1` to `n2` is a dataflow step that converts between `String` and `JMXServiceURL`
266+
* by calling `new JMXServiceURL(tainted)`.
267267
*/
268268
private predicate jmxServiceUrlStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
269269
exists(ConstructorCall cc | cc.getConstructedType() instanceof TypeJMXServiceURL |
@@ -274,7 +274,7 @@ private predicate jmxServiceUrlStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2
274274

275275
/**
276276
* Holds if `n1` to `n2` is a dataflow step that converts between `JMXServiceURL` and
277-
* `JMXConnector`, i.e. `JMXConnectorFactory.newJMXConnector(tainted)`.
277+
* `JMXConnector` by calling `JMXConnectorFactory.newJMXConnector(tainted)`.
278278
*/
279279
private predicate jmxConnectorStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
280280
exists(MethodAccess ma, Method m | n1.asExpr() = ma.getArgument(0) and n2.asExpr() = ma |
@@ -286,7 +286,7 @@ private predicate jmxConnectorStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2)
286286

287287
/**
288288
* Holds if `n1` to `n2` is a dataflow step that converts between `JMXServiceURL` and
289-
* `RMIConnector`, i.e. `new RMIConnector(tainted)`.
289+
* `RMIConnector` by calling `new RMIConnector(tainted)`.
290290
*/
291291
private predicate rmiConnectorStep(DataFlow::ExprNode n1, DataFlow::ExprNode n2) {
292292
exists(ConstructorCall cc | cc.getConstructedType() instanceof TypeRMIConnector |

0 commit comments

Comments
 (0)