Update InsufficientControlFlowManagementAfterRefactoringTheCode.ql

ihsinme · web-flow · commit 58d5ad48d56f · 2021-04-12T17:00:34.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-691/InsufficientControlFlowManagementAfterRefactoringTheCode.ql b/cpp/ql/src/experimental/Security/CWE/CWE-691/InsufficientControlFlowManagementAfterRefactoringTheCode.ql
@@ -105,7 +105,7 @@ class UsingArithmeticInComparison extends BinaryArithmeticOperation {
   }
 }
 
-from Expr exp, WhileStmt wst
+from Expr exp
 where
   exp instanceof UsingArithmeticInComparison and
   not exp.(UsingArithmeticInComparison).workingWithValue() and
@@ -114,5 +114,5 @@ where
   not exp.(UsingArithmeticInComparison).compareWithZero() and
   exp.(UsingArithmeticInComparison).compareWithOutZero()
   or
-  wst instanceof UsingWhileAfterWhile and exp = wst.getCondition()
+  exists(WhileStmt wst | wst instanceof UsingWhileAfterWhile and exp = wst.getCondition())
 select exp, "this expression needs your attention"

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ class UsingArithmeticInComparison extends BinaryArithmeticOperation {`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`
`108`		`-from Expr exp, WhileStmt wst`
	`108`	`+from Expr exp`
`109`	`109`	`where`
`110`	`110`	`exp instanceof UsingArithmeticInComparison and`
`111`	`111`	`not exp.(UsingArithmeticInComparison).workingWithValue() and`
`@@ -114,5 +114,5 @@ where`
`114`	`114`	`not exp.(UsingArithmeticInComparison).compareWithZero() and`
`115`	`115`	`exp.(UsingArithmeticInComparison).compareWithOutZero()`
`116`	`116`	`or`
`117`		`- wst instanceof UsingWhileAfterWhile and exp = wst.getCondition()`
	`117`	`+ exists(WhileStmt wst \| wst instanceof UsingWhileAfterWhile and exp = wst.getCondition())`
`118`	`118`	`select exp, "this expression needs your attention"`