Skip to content

Commit 5a42448

Browse files
committed
Code review suggestions
- Remove unneeded import - Remove unnecessary `toLowerCase` call
1 parent 69549e9 commit 5a42448

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

java/ql/src/semmle/code/java/frameworks/Jackson.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import java
6-
private import semmle.code.java.Reflection
76
private import semmle.code.java.dataflow.DataFlow
87

98
private class ObjectMapper extends RefType {

java/ql/src/semmle/code/java/security/UnsafeDeserializationQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ predicate resolveClassStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
271271
predicate looksLikeResolveClassStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
272272
exists(MethodAccess ma, Method m, Expr arg | m = ma.getMethod() and arg = ma.getAnArgument() |
273273
m.getReturnType() instanceof JacksonTypeDescriptorType and
274-
m.getName().toLowerCase().regexpMatch("(?i).*(resolve|load|class|type).*") and
274+
m.getName().regexpMatch("(?i).*(resolve|load|class|type).*") and
275275
arg.getType() instanceof TypeString and
276276
arg = fromNode.asExpr() and
277277
ma = toNode.asExpr()

0 commit comments

Comments
 (0)