Remove Class cast

edvraa · edvraa · commit 5eb96c1e4533 · 2021-04-27T20:26:29.000+03:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-730/RegexInjection.ql b/java/ql/src/experimental/Security/CWE/CWE-730/RegexInjection.ql
@@ -39,7 +39,7 @@ class RegexSink extends DataFlow::ExprNode {
         m.getDeclaringType().hasQualifiedName("org.apache.commons.lang3", "RegExUtils") and
         (
           ma.getArgument(1) = this.asExpr() and
-          m.getParameterType(1).(Class) instanceof TypeString and
+          m.getParameterType(1) instanceof TypeString and
           m.hasName([
               "removeAll", "removeFirst", "removePattern", "replaceAll", "replaceFirst",
               "replacePattern"

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class RegexSink extends DataFlow::ExprNode {`
`39`	`39`	`m.getDeclaringType().hasQualifiedName("org.apache.commons.lang3", "RegExUtils") and`
`40`	`40`	`(`
`41`	`41`	`ma.getArgument(1) = this.asExpr() and`
`42`		`- m.getParameterType(1).(Class) instanceof TypeString and`
	`42`	`+ m.getParameterType(1) instanceof TypeString and`
`43`	`43`	`m.hasName([`
`44`	`44`	`"removeAll", "removeFirst", "removePattern", "replaceAll", "replaceFirst",`
`45`	`45`	`"replacePattern"`