Skip to content

Commit 5fff41f

Browse files
committed
Don't track taint on Map keys
1 parent 5f2a5f1 commit 5fff41f

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

java/ql/src/semmle/code/java/dataflow/internal/ContainerFlow.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ private predicate taintPreservingArgumentToMethod(Method method, int arg) {
169169
method
170170
.hasName(["checkedCollection", "checkedList", "checkedMap", "checkedNavigableMap",
171171
"checkedNavigableSet", "checkedSet", "checkedSortedMap", "checkedSortedSet",
172-
"enumeration", "list", "max", "min", "singleton", "singletonList", "singletonMap",
172+
"enumeration", "list", "max", "min", "singleton", "singletonList",
173173
"synchronizedCollection", "synchronizedList", "synchronizedMap",
174174
"synchronizedNavigableMap", "synchronizedNavigableSet", "synchronizedSet",
175175
"synchronizedSortedMap", "synchronizedSortedSet", "unmodifiableCollection",

java/ql/test/library-tests/dataflow/local-additional-taint/localAdditionalTaintStep.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
| CollectionsTest.java:13:19:13:22 | list | CollectionsTest.java:13:3:13:23 | min(...) |
1212
| CollectionsTest.java:14:27:14:30 | list | CollectionsTest.java:14:3:14:31 | enumeration(...) |
1313
| CollectionsTest.java:15:20:15:30 | enumeration | CollectionsTest.java:15:3:15:31 | list(...) |
14-
| CollectionsTest.java:16:28:16:32 | "key" | CollectionsTest.java:16:3:16:42 | singletonMap(...) |
1514
| CollectionsTest.java:16:35:16:41 | "value" | CollectionsTest.java:16:3:16:42 | singletonMap(...) |
1615
| CollectionsTest.java:17:26:17:30 | other | CollectionsTest.java:17:20:17:23 | list [post update] |
1716
| CollectionsTest.java:18:27:18:32 | "item" | CollectionsTest.java:18:3:18:33 | nCopies(...) |

0 commit comments

Comments
 (0)