Skip to content

Commit 60a4a79

Browse files
committed
Make the Config module of public Flow modules public
This is to make things easier for the CodeML/ATM team once these configurations are moved from `src/` to `lib/`.
1 parent 7eb3fd2 commit 60a4a79

15 files changed

+17
-17
lines changed

java/ql/lib/semmle/code/java/security/XxeLocalQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ deprecated class XxeLocalConfig extends TaintTracking::Configuration {
2424
}
2525
}
2626

27-
private module XxeLocalConfig implements DataFlow::ConfigSig {
27+
module XxeLocalConfig implements DataFlow::ConfigSig {
2828
predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }
2929

3030
predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }

java/ql/lib/semmle/code/java/security/XxeRemoteQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ deprecated class XxeConfig extends TaintTracking::Configuration {
2424
}
2525
}
2626

27-
private module XxeConfig implements DataFlow::ConfigSig {
27+
module XxeConfig implements DataFlow::ConfigSig {
2828
predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
2929

3030
predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }

java/ql/src/Security/CWE/CWE-022/TaintedPathLocal.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import semmle.code.java.security.PathCreation
2020
import semmle.code.java.security.PathSanitizer
2121
import TaintedPathCommon
2222

23-
private module TaintedPathLocalConfig implements DataFlow::ConfigSig {
23+
module TaintedPathLocalConfig implements DataFlow::ConfigSig {
2424
predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
2525

2626
predicate isSink(DataFlow::Node sink) {

java/ql/src/Security/CWE/CWE-022/ZipSlip.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class ArchiveEntryNameMethod extends Method {
3434
}
3535
}
3636

37-
private module ZipSlipConfiguration implements DataFlow::ConfigSig {
37+
module ZipSlipConfiguration implements DataFlow::ConfigSig {
3838
predicate isSource(DataFlow::Node source) {
3939
source.asExpr().(MethodAccess).getMethod() instanceof ArchiveEntryNameMethod
4040
}

java/ql/src/Security/CWE/CWE-090/LdapInjectionLib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import semmle.code.java.security.LdapInjection
55
/**
66
* A taint-tracking configuration for unvalidated user input that is used to construct LDAP queries.
77
*/
8-
private module LdapInjectionFlowConfig implements DataFlow::ConfigSig {
8+
module LdapInjectionFlowConfig implements DataFlow::ConfigSig {
99
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
1010

1111
predicate isSink(DataFlow::Node sink) { sink instanceof LdapInjectionSink }

java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class SetMessageInterpolatorCall extends MethodAccess {
5555
* Taint tracking BeanValidationConfiguration describing the flow of data from user input
5656
* to the argument of a method that builds constraint error messages.
5757
*/
58-
private module BeanValidationConfig implements DataFlow::ConfigSig {
58+
module BeanValidationConfig implements DataFlow::ConfigSig {
5959
predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
6060

6161
predicate isSink(DataFlow::Node sink) { sink instanceof BeanValidationSink }

java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatStringLocal.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import java
1414
import semmle.code.java.dataflow.FlowSources
1515
import semmle.code.java.StringFormat
1616

17-
private module ExternallyControlledFormatStringLocalConfig implements DataFlow::ConfigSig {
17+
module ExternallyControlledFormatStringLocalConfig implements DataFlow::ConfigSig {
1818
predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
1919

2020
predicate isSink(DataFlow::Node sink) {

java/ql/src/Security/CWE/CWE-190/ArithmeticTaintedLocal.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import java
1616
import semmle.code.java.dataflow.FlowSources
1717
import ArithmeticCommon
1818

19-
private module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigSig {
19+
module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigSig {
2020
predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
2121

2222
predicate isSink(DataFlow::Node sink) { overflowSink(_, sink.asExpr()) }
@@ -27,7 +27,7 @@ private module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigS
2727
module ArithmeticTaintedLocalOverflowFlow =
2828
TaintTracking::Make<ArithmeticTaintedLocalOverflowConfig>;
2929

30-
private module ArithmeticTaintedLocalUnderflowConfig implements DataFlow::ConfigSig {
30+
module ArithmeticTaintedLocalUnderflowConfig implements DataFlow::ConfigSig {
3131
predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
3232

3333
predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }

java/ql/src/Security/CWE/CWE-190/ArithmeticUncontrolled.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class TaintSource extends DataFlow::ExprNode {
2424
}
2525
}
2626

27-
private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {
27+
module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {
2828
predicate isSource(DataFlow::Node source) { source instanceof TaintSource }
2929

3030
predicate isSink(DataFlow::Node sink) { overflowSink(_, sink.asExpr()) }
@@ -35,7 +35,7 @@ private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigS
3535
module ArithmeticUncontrolledOverflowFlow =
3636
TaintTracking::Make<ArithmeticUncontrolledOverflowConfig>;
3737

38-
private module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {
38+
module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {
3939
predicate isSource(DataFlow::Node source) { source instanceof TaintSource }
4040

4141
predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }

java/ql/src/Security/CWE/CWE-200/AndroidWebViewSettingsAllowsContentAccess.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ private newtype WebViewOrSettings =
6565
IsWebView() or
6666
IsSettings()
6767

68-
private module WebViewDisallowContentAccessConfig implements DataFlow::StateConfigSig {
68+
module WebViewDisallowContentAccessConfig implements DataFlow::StateConfigSig {
6969
class FlowState = WebViewOrSettings;
7070

7171
predicate isSource(DataFlow::Node node, FlowState state) {

0 commit comments

Comments
 (0)