Skip to content

Commit 60e7786

Browse files
committed
Python: Use explicit keyword parameter
1 parent 46e44a0 commit 60e7786

File tree

1 file changed

+7
-6
lines changed
  • python/ql/test/library-tests/frameworks/rest_framework

1 file changed

+7
-6
lines changed

python/ql/test/library-tests/frameworks/rest_framework/taint_test.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,19 @@ def get(self, request: Request, routed_param): # $ requestHandler routedParamete
112112
# see https://www.django-rest-framework.org/api-guide/viewsets/
113113

114114
class MyModelViewSet(ModelViewSet):
115-
def retrieve(self, request, *args, **kwargs): # $ requestHandler
115+
def retrieve(self, request, routed_param): # $ requestHandler routedParameter=routed_param
116116
ensure_tainted(
117117
request, # $ tainted
118118
request.GET, # $ tainted
119119
request.GET.get("pk"), # $ tainted
120+
request.data # $ tainted
120121
)
121122

122-
ensure_tainted(
123-
kwargs, # $ tainted
124-
kwargs["pk"], # $ tainted
125-
kwargs.get("pk"), # $ tainted
126-
)
123+
ensure_tainted(routed_param) # $ tainted
124+
125+
# same as for standard Django view
126+
ensure_tainted(self.args, self.kwargs) # $ tainted
127+
127128
return Response("retrieve") # $ HttpResponse
128129

129130

0 commit comments

Comments
 (0)