Skip to content

Commit 6159fbe

Browse files
committed
Update functions naming
1 parent 34b8af3 commit 6159fbe

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

python/ql/src/experimental/semmle/python/Concepts.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module LDAPQuery {
2626
/**
2727
* Gets the argument containing the executed expression.
2828
*/
29-
abstract DataFlow::Node getLDAPNode();
29+
abstract DataFlow::Node getQuery();
3030
}
3131
}
3232

@@ -44,7 +44,7 @@ class LDAPQuery extends DataFlow::Node {
4444
/**
4545
* Gets the argument containing the executed expression.
4646
*/
47-
DataFlow::Node getLDAPNode() { result = range.getLDAPNode() }
47+
DataFlow::Node getQuery() { result = range.getQuery() }
4848
}
4949

5050
/** Provides classes for modeling LDAP components escape-related APIs. */
@@ -59,7 +59,7 @@ module LDAPEscape {
5959
/**
6060
* Gets the argument containing the escaped expression.
6161
*/
62-
abstract DataFlow::Node getEscapeNode();
62+
abstract DataFlow::Node getAnInput();
6363
}
6464
}
6565

@@ -77,5 +77,5 @@ class LDAPEscape extends DataFlow::Node {
7777
/**
7878
* Gets the argument containing the escaped expression.
7979
*/
80-
DataFlow::Node getEscapeNode() { result = range.getEscapeNode() }
80+
DataFlow::Node getAnInput() { result = range.getAnInput() }
8181
}

python/ql/src/experimental/semmle/python/frameworks/LDAP.qll

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ private module LDAP {
3636
* See `LDAP2QueryMethods`
3737
*/
3838
private class LDAP2Query extends DataFlow::CallCfgNode, LDAPQuery::Range {
39-
DataFlow::Node ldapNode;
39+
DataFlow::Node ldapQuery;
4040

4141
LDAP2Query() {
4242
exists(DataFlow::AttrRead searchMethod |
@@ -45,17 +45,17 @@ private module LDAP {
4545
searchMethod.getObject().getALocalSource() and
4646
searchMethod.getAttributeName() instanceof LDAP2QueryMethods and
4747
(
48-
ldapNode = this.getArg(0)
48+
ldapQuery = this.getArg(0)
4949
or
5050
(
51-
ldapNode = this.getArg(2) or
52-
ldapNode = this.getArgByName("filterstr")
51+
ldapQuery = this.getArg(2) or
52+
ldapQuery = this.getArgByName("filterstr")
5353
)
5454
)
5555
)
5656
}
5757

58-
override DataFlow::Node getLDAPNode() { result = ldapNode }
58+
override DataFlow::Node getQuery() { result = ldapQuery }
5959
}
6060

6161
/**
@@ -68,7 +68,7 @@ private module LDAP {
6868
this = API::moduleImport("ldap").getMember("dn").getMember("escape_dn_chars").getACall()
6969
}
7070

71-
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
71+
override DataFlow::Node getAnInput() { result = this.getArg(0) }
7272
}
7373

7474
/**
@@ -82,7 +82,7 @@ private module LDAP {
8282
API::moduleImport("ldap").getMember("filter").getMember("escape_filter_chars").getACall()
8383
}
8484

85-
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
85+
override DataFlow::Node getAnInput() { result = this.getArg(0) }
8686
}
8787
}
8888

@@ -96,7 +96,7 @@ private module LDAP {
9696
* A class to find `ldap3` methods executing a query.
9797
*/
9898
private class LDAP3Query extends DataFlow::CallCfgNode, LDAPQuery::Range {
99-
DataFlow::Node ldapNode;
99+
DataFlow::Node ldapQuery;
100100

101101
LDAP3Query() {
102102
exists(DataFlow::AttrRead searchMethod |
@@ -105,13 +105,13 @@ private module LDAP {
105105
searchMethod.getObject().getALocalSource() and
106106
searchMethod.getAttributeName() = "search" and
107107
(
108-
ldapNode = this.getArg(0) or
109-
ldapNode = this.getArg(1)
108+
ldapQuery = this.getArg(0) or
109+
ldapQuery = this.getArg(1)
110110
)
111111
)
112112
}
113113

114-
override DataFlow::Node getLDAPNode() { result = ldapNode }
114+
override DataFlow::Node getQuery() { result = ldapQuery }
115115
}
116116

117117
/**
@@ -129,7 +129,7 @@ private module LDAP {
129129
.getACall()
130130
}
131131

132-
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
132+
override DataFlow::Node getAnInput() { result = this.getArg(0) }
133133
}
134134

135135
/**
@@ -147,7 +147,7 @@ private module LDAP {
147147
.getACall()
148148
}
149149

150-
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
150+
override DataFlow::Node getAnInput() { result = this.getArg(0) }
151151
}
152152
}
153153
}

0 commit comments

Comments
 (0)