Skip to content

Commit 631ee28

Browse files
committed
C++: update comments about SSA sharing
1 parent 50edf44 commit 631ee28

File tree

1 file changed

+2
-3
lines changed
  • cpp/ql/src/semmle/code/cpp/ir/implementation/internal

1 file changed

+2
-3
lines changed

cpp/ql/src/semmle/code/cpp/ir/implementation/internal/TOperand.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ private module Internal {
4343
} or
4444
//// ALIASED
4545
////
46-
// If we share SSA, these will be all the phis there are. Otherwise these
47-
// will add to the ones that are already there.
46+
// Until we share SSA, these will be all the phis there are. With SSA
47+
// sharing, these will add to the ones that are already there.
4848
// If we share SSA, be careful with the case where we remove all possible
4949
// indirect writes to a variable because they're dead code. In that case it's
5050
// important that we use the same definition of "is variable aliased" across
@@ -56,7 +56,6 @@ private module Internal {
5656
defInstr = AliasedConstruction::getPhiOperandDefinition(useInstr, predecessorBlock, overlap)
5757
} or
5858
TAliasedChiOperand(TAliasedSSAChiInstruction useInstr, ChiOperandTag tag) {
59-
// TODO: any further restrictions here?
6059
any()
6160
}
6261
}

0 commit comments

Comments
 (0)