Skip to content

Commit 6393dca

Browse files
author
edvraa
committed
Apply changes from code review
1 parent 3de7b28 commit 6393dca

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

csharp/ql/src/experimental/dataflow/flowsources/AuthCookie.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ class CookieOptionsTrackingConfiguration extends DataFlow::Configuration {
5252
override predicate isSink(DataFlow::Node sink) {
5353
exists(MicrosoftAspNetCoreHttpResponseCookies iResponse, MethodCall mc |
5454
iResponse.getAppendMethod() = mc.getTarget() and
55-
mc.getNumberOfArguments() > 2 and
5655
mc.getArgument(2) = sink.asExpr()
5756
)
5857
}
@@ -144,7 +143,7 @@ class OnAppendCookieHttpOnlyTrackingConfig extends OnAppendCookieTrackingConfig
144143
/**
145144
* Tracks if a callback used in `OnAppendCookie` sets a cookie property to `true`.
146145
*/
147-
abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
146+
private abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
148147
bindingset[this]
149148
OnAppendCookieTrackingConfig() { any() }
150149

0 commit comments

Comments
 (0)