Change names of configuration to fit new naming convention

Author: egregius313

java/ql/lib/semmle/code/java/security/InsecureLdapAuthQuery.qll

@@ -9,7 +9,7 @@ import semmle.code.java.security.InsecureLdapAuth
 /**
  * A taint-tracking configuration for `ldap://` URL in LDAP authentication.
  */
-private module InsecureUrlFlowConfig implements DataFlow::ConfigSig {
+private module InsecureLdapUrlConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src.asExpr() instanceof InsecureLdapUrl }
 
   predicate isSink(DataFlow::Node sink) {
@@ -29,12 +29,12 @@ private module InsecureUrlFlowConfig implements DataFlow::ConfigSig {
   }
 }
 
-module InsecureUrlFlowConfiguration = TaintTracking::Make<InsecureUrlFlowConfig>;
+module InsecureLdapUrlFlow = TaintTracking::Make<InsecureLdapUrlConfig>;
 
 /**
  * A taint-tracking configuration for `simple` basic-authentication in LDAP configuration.
  */
-private module BasicAuthFlowConfig implements DataFlow::ConfigSig {
+private module BasicAuthConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) {
     exists(MethodAccess ma |
       isBasicAuthEnv(ma) and ma.getQualifier() = src.(PostUpdateNode).getPreUpdateNode().asExpr()
@@ -49,7 +49,7 @@ private module BasicAuthFlowConfig implements DataFlow::ConfigSig {
   }
 }
 
-module BasicAuthFlowConfiguration = DataFlow::Make<BasicAuthFlowConfig>;
+module BasicAuthFlow = DataFlow::Make<BasicAuthConfig>;
 
 /**
  * A taint-tracking configuration for `ssl` configuration in LDAP authentication.
@@ -69,4 +69,4 @@ private module RequiresSslConfig implements DataFlow::ConfigSig {
   }
 }
 
-module RequiresSslConfiguration = DataFlow::Make<RequiresSslConfig>;
+module RequiresSslFlow = DataFlow::Make<RequiresSslConfig>;

java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql

@@ -14,12 +14,12 @@
 
 import java
 import semmle.code.java.security.InsecureLdapAuthQuery
-import InsecureUrlFlowConfiguration::PathGraph
+import InsecureLdapUrlFlow::PathGraph
 
-from InsecureUrlFlowConfiguration::PathNode source, InsecureUrlFlowConfiguration::PathNode sink
+from InsecureLdapUrlFlow::PathNode source, InsecureLdapUrlFlow::PathNode sink
 where
-  InsecureUrlFlowConfiguration::hasFlowPath(source, sink) and
-  BasicAuthFlowConfiguration::hasFlowTo(sink.getNode()) and
-  not RequiresSslConfiguration::hasFlowTo(sink.getNode())
+  InsecureLdapUrlFlow::hasFlowPath(source, sink) and
+  BasicAuthFlow::hasFlowTo(sink.getNode()) and
+  not RequiresSslFlow::hasFlowTo(sink.getNode())
 select sink.getNode(), source, sink, "Insecure LDAP authentication from $@.", source.getNode(),
   "LDAP connection string"

java/ql/test/query-tests/security/CWE-522/InsecureLdapAuthTest.ql

@@ -9,9 +9,9 @@ class InsecureLdapAuthenticationTest extends InlineExpectationsTest {
 
   override predicate hasActualResult(Location location, string element, string tag, string value) {
     tag = "hasInsecureLdapAuth" and
-    exists(DataFlow::Node sink | InsecureUrlFlowConfiguration::hasFlowTo(sink) |
-      BasicAuthFlowConfiguration::hasFlowTo(sink) and
-      not SslFlowConfiguration::hasFlowTo(sink) and
+    exists(DataFlow::Node sink | InsecureLdapUrlFlow::hasFlowTo(sink) |
+      BasicAuthFlow::hasFlowTo(sink) and
+      not RequiresSslFlow::hasFlowTo(sink) and
       sink.getLocation() = location and
       element = sink.toString() and
       value = ""