Merge pull request github#853 from joshhale/tweak-cwe-078-example

aschackmull · web-flow · commit 67b32796ddaa · 2020-02-24T16:15:58.000+01:00
doc: remove - from command arguments
diff --git a/java/ql/src/Security/CWE/CWE-078/ExecUnescaped.java b/java/ql/src/Security/CWE/CWE-078/ExecUnescaped.java
@@ -4,7 +4,7 @@ public static void main(String[] args) {
         {
             String latlonCoords = args[1];
             Runtime rt = Runtime.getRuntime();
-            Process exec = rt.exec("cmd.exe /C latlon2utm.exe -" + latlonCoords);
+            Process exec = rt.exec("cmd.exe /C latlon2utm.exe " + latlonCoords);
         }
 
         // GOOD: use an array of arguments instead of executing a string

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ public static void main(String[] args) {`
`4`	`4`	`{`
`5`	`5`	`String latlonCoords = args[1];`
`6`	`6`	`Runtime rt = Runtime.getRuntime();`
`7`		`- Process exec = rt.exec("cmd.exe /C latlon2utm.exe -" + latlonCoords);`
	`7`	`+ Process exec = rt.exec("cmd.exe /C latlon2utm.exe " + latlonCoords);`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`// GOOD: use an array of arguments instead of executing a string`