Skip to content

Commit 6a3859f

Browse files
committed
C#: Remove unnecessary pre call in FlowSummaryImpl.qll
1 parent 6bfc49c commit 6a3859f

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

csharp/ql/src/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -323,19 +323,19 @@ module Private {
323323
isParameterPostUpdate(_, c, i)
324324
}
325325

326-
private Node pre(Node post) {
327-
summaryPostUpdateNode(post, result)
328-
or
329-
not summaryPostUpdateNode(post, _) and
330-
result = post
331-
}
332-
333326
private predicate callbackOutput(
334327
SummarizedCallable c, SummaryComponentStack s, Node receiver, ReturnKind rk
335328
) {
336329
any(SummaryNodeState state).isInputState(c, s) and
337330
s.head() = TReturnSummaryComponent(rk) and
338-
receiver = pre(summaryNodeInputState(c, s.drop(1)))
331+
receiver = summaryNodeInputState(c, s.drop(1))
332+
}
333+
334+
private Node pre(Node post) {
335+
summaryPostUpdateNode(post, result)
336+
or
337+
not summaryPostUpdateNode(post, _) and
338+
result = post
339339
}
340340

341341
private predicate callbackInput(

0 commit comments

Comments
 (0)