Skip to content

Commit 6c78a24

Browse files
committed
Revert erroneous refactoring in header splitting sink base class
1 parent 9b1c54e commit 6c78a24

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

java/ql/src/semmle/code/java/security/ResponseSplitting.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ import semmle.code.java.frameworks.JaxWS
88
private import semmle.code.java.dataflow.ExternalFlow
99

1010
/** A sink that is vulnerable to an HTTP header splitting attack. */
11-
class HeaderSplittingSink extends DataFlow::Node {
12-
HeaderSplittingSink() { sinkNode(this, "header-splitting") }
11+
abstract class HeaderSplittingSink extends DataFlow::Node { }
12+
13+
private class DefaultHeaderSplittingSink extends HeaderSplittingSink {
14+
DefaultHeaderSplittingSink() { sinkNode(this, "header-splitting") }
1315
}
1416

1517
private class HeaderSplittingSinkModel extends SinkModelCsv {

0 commit comments

Comments
 (0)