Skip to content

Commit 6d79bab

Browse files
committed
rename Fs to FS
1 parent 7df35a6 commit 6d79bab

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ module NodeJSLib {
306306

307307
FsFlowTarget() {
308308
exists(DataFlow::CallNode call, string methodName |
309-
call = Fs::moduleMember(methodName).getACall()
309+
call = FS::moduleMember(methodName).getACall()
310310
|
311311
methodName = "realpathSync" and
312312
tainted = call.getArgument(0) and
@@ -432,7 +432,7 @@ module NodeJSLib {
432432
/**
433433
* Provides predicates for working with the "fs" module and its variants as a single module.
434434
*/
435-
module Fs {
435+
module FS {
436436
/**
437437
* A member `member` from module `fs` or its drop-in replacements `graceful-fs`, `fs-extra`, `original-fs`.
438438
*/
@@ -464,7 +464,7 @@ module NodeJSLib {
464464
private class NodeJSFileSystemAccess extends FileSystemAccess, DataFlow::CallNode {
465465
string methodName;
466466

467-
NodeJSFileSystemAccess() { this = maybePromisified(Fs::moduleMember(methodName)).getACall() }
467+
NodeJSFileSystemAccess() { this = maybePromisified(FS::moduleMember(methodName)).getACall() }
468468

469469
/**
470470
* Gets the name of the called method.
@@ -587,8 +587,8 @@ module NodeJSLib {
587587
name = "readdir" or
588588
name = "realpath"
589589
|
590-
this = Fs::moduleMember(name).getACall().getCallback([1 .. 2]).getParameter(1) or
591-
this = Fs::moduleMember(name + "Sync").getACall()
590+
this = FS::moduleMember(name).getACall().getCallback([1 .. 2]).getParameter(1) or
591+
this = FS::moduleMember(name + "Sync").getACall()
592592
)
593593
}
594594
}

javascript/ql/src/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,11 @@ module TaintedPath {
155155
input = getAnArgument() and
156156
output = this
157157
or
158-
this = NodeJSLib::Fs::moduleMember("realpathSync").getACall() and
158+
this = NodeJSLib::FS::moduleMember("realpathSync").getACall() and
159159
input = getArgument(0) and
160160
output = this
161161
or
162-
this = NodeJSLib::Fs::moduleMember("realpath").getACall() and
162+
this = NodeJSLib::FS::moduleMember("realpath").getACall() and
163163
input = getArgument(0) and
164164
output = getCallback(1).getParameter(1)
165165
}

javascript/ql/src/semmle/javascript/security/dataflow/ZipSlipCustomizations.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ module ZipSlip {
107107
// However, we want to consider even the bare `createWriteStream`
108108
// to be a zipslip vulnerability since it may truncate an
109109
// existing file.
110-
this = NodeJSLib::Fs::moduleMember("createWriteStream").getACall().getArgument(0)
110+
this = NodeJSLib::FS::moduleMember("createWriteStream").getACall().getArgument(0)
111111
or
112112
// Not covered by `FileSystemWriteSink` because a later call
113113
// to `fs.write` is required for a write to take place.
114114
exists(DataFlow::CallNode call | this = call.getArgument(0) |
115-
call = NodeJSLib::Fs::moduleMember(["open", "openSync"]).getACall() and
115+
call = NodeJSLib::FS::moduleMember(["open", "openSync"]).getACall() and
116116
call.getArgument(1).getStringValue().regexpMatch("(?i)w.{0,2}")
117117
)
118118
}

0 commit comments

Comments
 (0)