Skip to content

Commit 6de5b30

Browse files
committed
C++: Replace Jira ticket reference with GH issue
1 parent 6e059ea commit 6de5b30

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

cpp/ql/src/semmle/code/cpp/controlflow/internal/CFG.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1307,7 +1307,8 @@ private predicate conditionJumps(Expr test, boolean truth, Node n2, Pos p2) {
13071307
)
13081308
}
13091309

1310-
// Factored out for performance. See QL-796.
1310+
// Pulled out for performance. See
1311+
// https://github.com/github/codeql-coreql-team/issues/1044.
13111312
private predicate normalGroupMemberBaseCase(Node memberNode, Pos memberPos, Node atNode) {
13121313
memberNode = atNode and
13131314
memberPos.isAt() and

cpp/ql/src/semmle/code/cpp/controlflow/internal/ConstantExprs.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ private predicate callHasNoTarget(@funbindexpr fc) {
128128
)
129129
}
130130

131-
// This base case is pulled out to work around QL-796
131+
// Pulled out for performance. See
132+
// https://github.com/github/codeql-coreql-team/issues/1044.
132133
private predicate potentiallyReturningFunctionCall_base(FunctionCall fc) {
133134
fc.isVirtual()
134135
or

cpp/ql/src/semmle/code/cpp/exprs/Expr.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1271,7 +1271,8 @@ private predicate convparents(Expr child, int idx, Element parent) {
12711271
)
12721272
}
12731273

1274-
// Pulled out for performance. See QL-796.
1274+
// Pulled out for performance. See
1275+
// https://github.com/github/codeql-coreql-team/issues/1044.
12751276
private predicate hasNoConversions(Expr e) { not e.hasConversion() }
12761277

12771278
/**

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ IRTempVariable getIRTempVariable(Locatable ast, TempVariableTag tag) {
4242
*/
4343
predicate isIRConstant(Expr expr) { exists(expr.getValue()) }
4444

45-
// Pulled out to work around QL-796
45+
// Pulled out for performance. See
46+
// https://github.com/github/codeql-coreql-team/issues/1044.
4647
private predicate isOrphan(Expr expr) { not exists(getRealParent(expr)) }
4748

4849
/**

csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedElement.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ private Element getRealParent(Expr expr) { result = expr.getParent() }
5757
*/
5858
predicate isIRConstant(Expr expr) { exists(expr.getValue()) }
5959

60-
// Pulled out to work around QL-796
60+
// Pulled out for performance. See
61+
// https://github.com/github/codeql-coreql-team/issues/1044.
6162
private predicate isOrphan(Expr expr) { not exists(getRealParent(expr)) }
6263

6364
/**

0 commit comments

Comments
 (0)