Skip to content

Commit 6e29171

Browse files
geoffw0geoffw0
committed
Swift: Update just enough tests to prove that that source labels are working.
1 parent fca6ccd commit 6e29171

File tree

7 files changed

+80
-92
lines changed

7 files changed

+80
-92
lines changed

‎swift/ql/test/library-tests/dataflow/dataflow/DataFlow.expected

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,6 @@ edges
604604
| test.swift:884:15:884:15 | generator [Collection element] | test.swift:884:15:884:30 | call to next() [some:0] |
605605
| test.swift:884:15:884:30 | call to next() [some:0] | test.swift:884:15:884:31 | ...! |
606606
| test.swift:908:19:908:26 | call to source() | test.swift:904:13:904:18 | call to ... |
607-
| test.swift:927:12:927:21 | call to source() | test.swift:927:12:927:21 | OpenExistentialExpr |
608-
| test.swift:929:12:929:35 | call to source() | test.swift:929:12:929:35 | OpenExistentialExpr |
609607
nodes
610608
| file://:0:0:0:0 | .a [x] | semmle.label | .a [x] |
611609
| file://:0:0:0:0 | .s [x] | semmle.label | .s [x] |
@@ -1256,12 +1254,6 @@ nodes
12561254
| test.swift:884:15:884:31 | ...! | semmle.label | ...! |
12571255
| test.swift:904:13:904:18 | call to ... | semmle.label | call to ... |
12581256
| test.swift:908:19:908:26 | call to source() | semmle.label | call to source() |
1259-
| test.swift:927:12:927:21 | OpenExistentialExpr | semmle.label | OpenExistentialExpr |
1260-
| test.swift:927:12:927:21 | call to source() | semmle.label | call to source() |
1261-
| test.swift:928:12:928:21 | call to source() | semmle.label | call to source() |
1262-
| test.swift:929:12:929:35 | OpenExistentialExpr | semmle.label | OpenExistentialExpr |
1263-
| test.swift:929:12:929:35 | call to source() | semmle.label | call to source() |
1264-
| test.swift:930:12:930:39 | call to source() | semmle.label | call to source() |
12651257
subpaths
12661258
| test.swift:75:22:75:22 | x | test.swift:65:16:65:28 | arg1 | test.swift:65:1:70:1 | arg2[return] | test.swift:75:32:75:32 | [post] y |
12671259
| test.swift:114:19:114:19 | arg | test.swift:109:9:109:14 | arg | test.swift:110:12:110:12 | arg | test.swift:114:12:114:22 | call to ... |
@@ -1460,7 +1452,3 @@ subpaths
14601452
| test.swift:880:19:880:19 | elem | test.swift:877:21:877:28 | call to source() | test.swift:880:19:880:19 | elem | result |
14611453
| test.swift:884:15:884:31 | ...! | test.swift:877:21:877:28 | call to source() | test.swift:884:15:884:31 | ...! | result |
14621454
| test.swift:904:13:904:18 | call to ... | test.swift:908:19:908:26 | call to source() | test.swift:904:13:904:18 | call to ... | result |
1463-
| test.swift:927:12:927:21 | OpenExistentialExpr | test.swift:927:12:927:21 | call to source() | test.swift:927:12:927:21 | OpenExistentialExpr | result |
1464-
| test.swift:928:12:928:21 | call to source() | test.swift:928:12:928:21 | call to source() | test.swift:928:12:928:21 | call to source() | result |
1465-
| test.swift:929:12:929:35 | OpenExistentialExpr | test.swift:929:12:929:35 | call to source() | test.swift:929:12:929:35 | OpenExistentialExpr | result |
1466-
| test.swift:930:12:930:39 | call to source() | test.swift:930:12:930:39 | call to source() | test.swift:930:12:930:39 | call to source() | result |

‎swift/ql/test/library-tests/dataflow/dataflow/LocalFlow.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,11 +1159,11 @@
11591159
| test.swift:917:7:917:7 | SSA def(self) | test.swift:917:7:917:7 | self[return] |
11601160
| test.swift:917:7:917:7 | self | test.swift:917:7:917:7 | SSA def(self) |
11611161
| test.swift:917:7:917:7 | self | test.swift:917:7:917:7 | SSA def(self) |
1162-
| test.swift:918:7:918:7 | SSA def(self) | test.swift:918:2:918:34 | self[return] |
1162+
| test.swift:918:7:918:7 | SSA def(self) | test.swift:918:2:918:49 | self[return] |
11631163
| test.swift:918:7:918:7 | self | test.swift:918:7:918:7 | SSA def(self) |
11641164
| test.swift:926:30:926:33 | SSA def(x) | test.swift:927:12:927:12 | x |
11651165
| test.swift:926:30:926:33 | x | test.swift:926:30:926:33 | SSA def(x) |
11661166
| test.swift:926:45:926:48 | SSA def(y) | test.swift:928:12:928:12 | y |
11671167
| test.swift:926:45:926:48 | y | test.swift:926:45:926:48 | SSA def(y) |
1168-
| test.swift:927:12:927:21 | call to source() | test.swift:927:12:927:21 | OpenExistentialExpr |
1169-
| test.swift:929:12:929:35 | call to source() | test.swift:929:12:929:35 | OpenExistentialExpr |
1168+
| test.swift:927:12:927:31 | call to source(_:) | test.swift:927:12:927:31 | OpenExistentialExpr |
1169+
| test.swift:929:12:929:57 | call to source(_:) | test.swift:929:12:929:57 | OpenExistentialExpr |

‎swift/ql/test/library-tests/dataflow/dataflow/test.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -911,11 +911,11 @@ func autoclosureTest() {
911911
// ---
912912

913913
protocol MyProtocol {
914-
func source() -> Int
914+
func source(_ label: String) -> Int
915915
}
916916

917917
class MyProcotolImpl : MyProtocol {
918-
func source() -> Int { return 0 }
918+
func source(_ label: String) -> Int { return 0 }
919919
}
920920

921921
func getMyProtocol() -> MyProtocol { return MyProcotolImpl() }
@@ -924,10 +924,10 @@ func getMyProtocolImpl() -> MyProcotolImpl { return MyProcotolImpl() }
924924
func sink(arg: Int) { }
925925

926926
func testOpenExistentialExpr(x: MyProtocol, y: MyProcotolImpl) {
927-
sink(arg: x.source()) // $ flow=927
928-
sink(arg: y.source()) // $ flow=928
929-
sink(arg: getMyProtocol().source()) // $ flow=929
930-
sink(arg: getMyProtocolImpl().source()) // $ flow=930
927+
sink(arg: x.source("x.source")) // $ flow=x.source
928+
sink(arg: y.source("y.source")) // $ flow=y.source
929+
sink(arg: getMyProtocol().source("getMyProtocol.source")) // $ flow=getMyProtocol.source
930+
sink(arg: getMyProtocolImpl().source("getMyProtocolImpl.source")) // $ flow=getMyProtocolImpl.source
931931
}
932932

933933
// ---

‎swift/ql/test/library-tests/dataflow/taint/core/LocalTaint.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
| conversions.swift:170:2:170:2 | self | conversions.swift:170:2:170:2 | SSA def(self) |
188188
| conversions.swift:171:7:171:7 | SSA def(arr1) | conversions.swift:173:13:173:13 | arr1 |
189189
| conversions.swift:171:7:171:7 | arr1 | conversions.swift:171:7:171:7 | SSA def(arr1) |
190-
| conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:171:7:171:7 | arr1 |
190+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:171:7:171:7 | arr1 |
191191
| conversions.swift:172:7:172:7 | SSA def(arr2) | conversions.swift:174:13:174:13 | arr2 |
192192
| conversions.swift:172:7:172:7 | arr2 | conversions.swift:172:7:172:7 | SSA def(arr2) |
193193
| conversions.swift:172:14:172:26 | [...] | conversions.swift:172:7:172:7 | arr2 |

‎swift/ql/test/library-tests/dataflow/taint/core/Taint.expected

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ edges
100100
| conversions.swift:156:25:156:69 | call to unsafeDowncast(_:to:) | conversions.swift:158:12:158:12 | v3 |
101101
| conversions.swift:156:40:156:40 | parent | conversions.swift:156:25:156:69 | call to unsafeDowncast(_:to:) |
102102
| conversions.swift:166:24:166:34 | call to sourceInt() | conversions.swift:166:12:166:35 | call to Self.init(_:) |
103-
| conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:173:13:173:13 | arr1 |
104-
| conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:175:13:175:19 | ...[...] |
105-
| conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:178:25:178:25 | arr1 |
106-
| conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:185:31:185:31 | arr1 |
103+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:173:13:173:13 | arr1 |
104+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:175:13:175:19 | ...[...] |
105+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:178:25:178:25 | arr1 |
106+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:185:31:185:31 | arr1 |
107107
| conversions.swift:172:14:172:26 | [...] [Collection element] | conversions.swift:174:13:174:13 | arr2 |
108108
| conversions.swift:172:14:172:26 | [...] [Collection element] | conversions.swift:176:13:176:13 | arr2 [Collection element] |
109109
| conversions.swift:172:14:172:26 | [...] [Collection element] | conversions.swift:176:13:176:19 | ...[...] |
@@ -357,7 +357,7 @@ nodes
357357
| conversions.swift:158:12:158:12 | v3 | semmle.label | v3 |
358358
| conversions.swift:166:12:166:35 | call to Self.init(_:) | semmle.label | call to Self.init(_:) |
359359
| conversions.swift:166:24:166:34 | call to sourceInt() | semmle.label | call to sourceInt() |
360-
| conversions.swift:171:14:171:26 | call to sourceArray() | semmle.label | call to sourceArray() |
360+
| conversions.swift:171:14:171:33 | call to sourceArray(_:) | semmle.label | call to sourceArray(_:) |
361361
| conversions.swift:172:14:172:26 | [...] [Collection element] | semmle.label | [...] [Collection element] |
362362
| conversions.swift:172:15:172:25 | call to sourceInt() | semmle.label | call to sourceInt() |
363363
| conversions.swift:173:13:173:13 | arr1 | semmle.label | arr1 |
@@ -573,17 +573,17 @@ subpaths
573573
| conversions.swift:157:12:157:12 | v3 | conversions.swift:152:31:152:44 | call to sourceString() | conversions.swift:157:12:157:12 | v3 | result |
574574
| conversions.swift:158:12:158:12 | v3 | conversions.swift:152:31:152:44 | call to sourceString() | conversions.swift:158:12:158:12 | v3 | result |
575575
| conversions.swift:166:12:166:35 | call to Self.init(_:) | conversions.swift:166:24:166:34 | call to sourceInt() | conversions.swift:166:12:166:35 | call to Self.init(_:) | result |
576-
| conversions.swift:173:13:173:13 | arr1 | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:173:13:173:13 | arr1 | result |
576+
| conversions.swift:173:13:173:13 | arr1 | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:173:13:173:13 | arr1 | result |
577577
| conversions.swift:174:13:174:13 | arr2 | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:174:13:174:13 | arr2 | result |
578-
| conversions.swift:175:13:175:19 | ...[...] | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:175:13:175:19 | ...[...] | result |
578+
| conversions.swift:175:13:175:19 | ...[...] | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:175:13:175:19 | ...[...] | result |
579579
| conversions.swift:176:13:176:19 | ...[...] | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:176:13:176:19 | ...[...] | result |
580-
| conversions.swift:180:13:180:13 | arr1b | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:180:13:180:13 | arr1b | result |
580+
| conversions.swift:180:13:180:13 | arr1b | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:180:13:180:13 | arr1b | result |
581581
| conversions.swift:181:13:181:13 | arr2b | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:181:13:181:13 | arr2b | result |
582-
| conversions.swift:182:13:182:20 | ...[...] | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:182:13:182:20 | ...[...] | result |
582+
| conversions.swift:182:13:182:20 | ...[...] | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:182:13:182:20 | ...[...] | result |
583583
| conversions.swift:183:13:183:20 | ...[...] | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:183:13:183:20 | ...[...] | result |
584-
| conversions.swift:187:13:187:13 | arr1c | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:187:13:187:13 | arr1c | result |
584+
| conversions.swift:187:13:187:13 | arr1c | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:187:13:187:13 | arr1c | result |
585585
| conversions.swift:188:13:188:13 | arr2c | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:188:13:188:13 | arr2c | result |
586-
| conversions.swift:189:13:189:20 | ...[...] | conversions.swift:171:14:171:26 | call to sourceArray() | conversions.swift:189:13:189:20 | ...[...] | result |
586+
| conversions.swift:189:13:189:20 | ...[...] | conversions.swift:171:14:171:33 | call to sourceArray(_:) | conversions.swift:189:13:189:20 | ...[...] | result |
587587
| conversions.swift:190:13:190:20 | ...[...] | conversions.swift:172:15:172:25 | call to sourceInt() | conversions.swift:190:13:190:20 | ...[...] | result |
588588
| simple.swift:12:13:12:24 | ... .+(_:_:) ... | simple.swift:12:17:12:24 | call to source() | simple.swift:12:13:12:24 | ... .+(_:_:) ... | result |
589589
| simple.swift:13:13:13:24 | ... .+(_:_:) ... | simple.swift:13:13:13:20 | call to source() | simple.swift:13:13:13:24 | ... .+(_:_:) ... | result |

‎swift/ql/test/library-tests/dataflow/taint/core/conversions.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ func sourceFloat() -> Float { 0.0 }
66
func sourceFloat80() -> Float80 { 0.0 }
77
func sourceDouble() -> Double { 0.0 }
88
func sourceString() -> String { "" }
9-
func sourceArray() -> [Int] { [] }
9+
func sourceArray(_ label: String) -> [Int] { [] }
1010

1111
func sink(arg: Any) { }
1212

@@ -168,25 +168,25 @@ func testCEnum() {
168168

169169
class TestArrayConversion {
170170
init() {
171-
let arr1 = sourceArray()
171+
let arr1 = sourceArray("init1")
172172
let arr2 = [sourceInt()]
173-
sink(arg: arr1) // $ tainted=171
173+
sink(arg: arr1) // $ tainted=init1
174174
sink(arg: arr2) // $ tainted=172
175-
sink(arg: arr1[0]) // $ tainted=171
175+
sink(arg: arr1[0]) // $ tainted=init1
176176
sink(arg: arr2[0]) // $ tainted=172
177177

178178
let arr1b = try Array(arr1)
179179
let arr2b = try Array(arr2)
180-
sink(arg: arr1b) // $ tainted=171
180+
sink(arg: arr1b) // $ tainted=init1
181181
sink(arg: arr2b) // $ tainted=172
182-
sink(arg: arr1b[0]) // $ tainted=171
182+
sink(arg: arr1b[0]) // $ tainted=init1
183183
sink(arg: arr2b[0]) // $ tainted=172
184184

185185
let arr1c = ContiguousArray(arr1)
186186
let arr2c = ContiguousArray(arr2)
187-
sink(arg: arr1c) // $ tainted=171
187+
sink(arg: arr1c) // $ tainted=init1
188188
sink(arg: arr2c) // $ tainted=172
189-
sink(arg: arr1c[0]) // $ tainted=171
189+
sink(arg: arr1c[0]) // $ tainted=init1
190190
sink(arg: arr2c[0]) // $ tainted=172
191191
}
192192
}

‎swift/ql/test/library-tests/dataflow/taint/libraries/int.swift

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -3,38 +3,38 @@
33

44
// --- tests ---
55

6-
func source() -> UInt8 { return 0; }
6+
func source(_ label: String) -> UInt8 { return 0; }
77
func source2() -> Int { return 0; }
88
func sink(arg: Any) {}
99

1010
func taintThroughClosurePointer() {
1111
var myArray1: [UInt8] = [1, 2, 3, 4]
1212

13-
myArray1[0] = source()
14-
sink(arg: myArray1) // $ tainted=13
15-
sink(arg: myArray1[0]) // $ tainted=13
13+
myArray1[0] = source("myArray1")
14+
sink(arg: myArray1) // $ tainted=myArray1
15+
sink(arg: myArray1[0]) // $ tainted=myArray1
1616
let return1 = myArray1.withUnsafeBytes({
1717
ptr1 in
18-
sink(arg: ptr1) // $ tainted=13
19-
sink(arg: ptr1[0]) // $ tainted=13
20-
return source()
18+
sink(arg: ptr1) // $ tainted=myArray1
19+
sink(arg: ptr1[0]) // $ tainted=myArray1
20+
return source("return1")
2121
})
22-
sink(arg: return1) // $ tainted=20
22+
sink(arg: return1) // $ tainted=return1
2323

2424
// ---
2525

2626
var myArray2: [UInt8] = [1, 2, 3, 4]
2727

28-
myArray2[0] = source()
29-
sink(arg: myArray2) // $ tainted=28
30-
sink(arg: myArray2[0]) // $ tainted=28
28+
myArray2[0] = source("myArray2")
29+
sink(arg: myArray2) // $ tainted=myArray2
30+
sink(arg: myArray2[0]) // $ tainted=myArray2
3131
let return2 = myArray2.withUnsafeBufferPointer({
3232
ptr2 in
33-
sink(arg: ptr2) // $ tainted=28
34-
sink(arg: ptr2[0]) // $ tainted=28
35-
return source()
33+
sink(arg: ptr2) // $ tainted=myArray2
34+
sink(arg: ptr2[0]) // $ tainted=myArray2
35+
return source("return2")
3636
})
37-
sink(arg: return2) // $ tainted=35
37+
sink(arg: return2) // $ tainted=return2
3838
}
3939

4040
func taintThroughMutablePointer() {
@@ -44,15 +44,15 @@ func taintThroughMutablePointer() {
4444
sink(arg: myArray1[0])
4545
let return1 = myArray1.withUnsafeMutableBufferPointer({
4646
buffer in
47-
buffer.update(repeating: source())
48-
sink(arg: buffer) // $ tainted=47
49-
sink(arg: buffer[0]) // $ tainted=47
50-
sink(arg: buffer.baseAddress!.pointee) // $ MISSING: tainted=47
51-
return source()
47+
buffer.update(repeating: source("array1write"))
48+
sink(arg: buffer) // $ tainted=array1write
49+
sink(arg: buffer[0]) // $ tainted=array1write
50+
sink(arg: buffer.baseAddress!.pointee) // $ MISSING: tainted=array1write
51+
return source("return1")
5252
})
53-
sink(arg: return1) // $ tainted=51
54-
sink(arg: myArray1) // $ tainted=47
55-
sink(arg: myArray1[0]) // $ tainted=47
53+
sink(arg: return1) // $ tainted=return1
54+
sink(arg: myArray1) // $ tainted=array1write
55+
sink(arg: myArray1[0]) // $ tainted=array1write
5656

5757
// ---
5858

@@ -62,15 +62,15 @@ func taintThroughMutablePointer() {
6262
sink(arg: myArray2[0])
6363
let return2 = myArray2.withUnsafeMutableBufferPointer({
6464
buffer in
65-
buffer.baseAddress!.pointee = source()
65+
buffer.baseAddress!.pointee = source("array2write")
6666
sink(arg: buffer)
67-
sink(arg: buffer[0]) // $ MISSING: tainted=65
68-
sink(arg: buffer.baseAddress!.pointee) // $ MISSING: tainted=65
69-
return source()
67+
sink(arg: buffer[0]) // $ MISSING: tainted=array2write
68+
sink(arg: buffer.baseAddress!.pointee) // $ MISSING: tainted=array2write
69+
return source("return2")
7070
})
71-
sink(arg: return2) // $ tainted=69
71+
sink(arg: return2) // $ tainted=return2
7272
sink(arg: myArray2)
73-
sink(arg: myArray2[0]) // $ MISSING: tainted=65
73+
sink(arg: myArray2[0]) // $ MISSING: tainted=array2write
7474

7575
// ---
7676

@@ -80,44 +80,44 @@ func taintThroughMutablePointer() {
8080
sink(arg: myArray3[0])
8181
let return3 = myArray3.withContiguousMutableStorageIfAvailable({
8282
ptr in
83-
ptr.update(repeating: source())
84-
sink(arg: ptr) // $ tainted=83
85-
sink(arg: ptr[0]) // $ tainted=83
86-
return source()
83+
ptr.update(repeating: source("array3write"))
84+
sink(arg: ptr) // $ tainted=array3write
85+
sink(arg: ptr[0]) // $ tainted=array3write
86+
return source("return3")
8787
})
88-
sink(arg: return3!) // $ tainted=86
89-
sink(arg: myArray3) // $ tainted=83
90-
sink(arg: myArray3[0]) // $ tainted=83
88+
sink(arg: return3!) // $ tainted=return3
89+
sink(arg: myArray3) // $ tainted=array3write
90+
sink(arg: myArray3[0]) // $ tainted=array3write
9191

9292
// ---
9393

9494
var myArray4: [UInt8] = [1, 2, 3, 4]
9595
var myArray5: [UInt8] = [5, 6, 7, 8]
9696

97-
myArray5[0] = source()
97+
myArray5[0] = source("array5write")
9898
sink(arg: myArray4)
9999
sink(arg: myArray4[0])
100-
sink(arg: myArray5) // $ tainted=97
101-
sink(arg: myArray5[0]) // $ tainted=97
100+
sink(arg: myArray5) // $ tainted=array5write
101+
sink(arg: myArray5[0]) // $ tainted=array5write
102102
let return4 = myArray4.withUnsafeMutableBytes({
103103
ptr4 in
104104
let return5 = myArray5.withUnsafeBytes({
105105
ptr5 in
106-
sink(arg: ptr5) // $ tainted=97
107-
sink(arg: ptr5[0]) // $ tainted=97
106+
sink(arg: ptr5) // $ tainted=array5write
107+
sink(arg: ptr5[0]) // $ tainted=array5write
108108
ptr4.copyBytes(from: ptr5)
109109
sink(arg: ptr4)
110-
sink(arg: ptr4[0]) // $ MISSING: tainted=97
111-
return source()
110+
sink(arg: ptr4[0]) // $ MISSING: tainted=array5write
111+
return source("return5")
112112
})
113-
sink(arg: return5) // $ tainted=111
114-
return source()
113+
sink(arg: return5) // $ tainted=return5
114+
return source("return4")
115115
})
116-
sink(arg: return4) // $ tainted=114
116+
sink(arg: return4) // $ tainted=return4
117117
sink(arg: myArray4)
118-
sink(arg: myArray4[0]) // $ MISSING: tainted=97
119-
sink(arg: myArray5) // $ tainted=97
120-
sink(arg: myArray5[0]) // $ tainted=97
118+
sink(arg: myArray4[0]) // $ MISSING: tainted=array5write
119+
sink(arg: myArray5) // $ tainted=array5write
120+
sink(arg: myArray5[0]) // $ tainted=array5write
121121

122122
// ---
123123

@@ -131,9 +131,9 @@ func taintThroughMutablePointer() {
131131
ptr.update(repeating: source2())
132132
sink(arg: ptr) // $ tainted=131
133133
sink(arg: ptr[0]) // $ tainted=131
134-
return source()
134+
return source("return6")
135135
})
136-
sink(arg: return6!) // $ tainted=134
136+
sink(arg: return6!) // $ tainted=return6
137137
sink(arg: myMutableBuffer) // $ tainted=131
138138
sink(arg: myMutableBuffer[0]) // $ tainted=131
139139
}

0 commit comments

Comments
 (0)