Skip to content

Commit 711a74c

Browse files
committed
Eliminate false positives\
1 parent e813257 commit 711a74c

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

java/ql/src/experimental/Security/CWE/CWE-348/UseOfLessTrustedSourceLib.qll

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,12 @@ private class CompareSink extends UseOfLessTrustedSink {
4141
ma.getMethod().getNumberOfParameters() = 1 and
4242
(
4343
ma.getArgument(0) = this.asExpr() and
44-
ma.getQualifier().(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName
44+
ma.getQualifier().(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName and
45+
not ma.getQualifier().(CompileTimeConstantExpr).getStringValue() = "0:0:0:0:0:0:0:1"
4546
or
4647
ma.getQualifier() = this.asExpr() and
47-
ma.getArgument(0).(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName
48+
ma.getArgument(0).(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName and
49+
not ma.getArgument(0).(CompileTimeConstantExpr).getStringValue() = "0:0:0:0:0:0:0:1"
4850
)
4951
)
5052
or
@@ -79,7 +81,8 @@ private class CompareSink extends UseOfLessTrustedSink {
7981
.hasQualifiedName(["org.apache.commons.lang3", "org.apache.commons.lang"], "StringUtils") and
8082
ma.getMethod().getNumberOfParameters() = 2 and
8183
ma.getAnArgument() = this.asExpr() and
82-
ma.getAnArgument().(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName
84+
ma.getAnArgument().(CompileTimeConstantExpr).getStringValue() instanceof PrivateHostName and
85+
not ma.getAnArgument().(CompileTimeConstantExpr).getStringValue() = "0:0:0:0:0:0:0:1"
8386
)
8487
}
8588
}

0 commit comments

Comments
 (0)