Skip to content

Commit 721713b

Browse files
RasmusWLtausbn
andauthored
Python: Minor fixes from code review
Co-authored-by: Taus <[email protected]>
1 parent baa415f commit 721713b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

python/ql/src/Variables/UndefinedExport.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ predicate mutates_globals(ModuleValue m) {
4040
(
4141
// In Python < 3.8, Enum._convert can be found with points-to
4242
exists(Value enum_convert |
43-
enum_convert = enum_class.attr(["_convert"]) and
43+
enum_convert = enum_class.attr("_convert") and
4444
exists(CallNode call | call.getScope() = m.getScope() |
4545
enum_convert.getACall() = call or
4646
call.getFunction().pointsTo(enum_convert)
4747
)
4848
)
4949
or
5050
// In Python 3.8, Enum._convert_ is implemented using a metaclass, and our points-to
51-
// analysis doesn't handle that good enough. So we need special case for this
51+
// analysis doesn't handle that well enough. So we need a special case for this
5252
not exists(Value enum_convert | enum_convert = enum_class.attr("_convert")) and
5353
exists(CallNode call | call.getScope() = m.getScope() |
5454
call.getFunction().(AttrNode).getObject(["_convert", "_convert_"]).pointsTo() =

0 commit comments

Comments
 (0)